From e18102313d1ec96976883b740da04acee314c92c Mon Sep 17 00:00:00 2001 From: Maxime Rivest Date: Mon, 5 Feb 2024 09:50:24 -0500 Subject: [PATCH 1/3] fix joins because of changes in polars api --- tidypolars/tibble.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tidypolars/tibble.py b/tidypolars/tibble.py index 4d7d177..0a28be5 100644 --- a/tidypolars/tibble.py +++ b/tidypolars/tibble.py @@ -345,7 +345,7 @@ def inner_join(self, df, left_on = None, right_on = None, on = None, suffix = '_ """ if (left_on == None) & (right_on == None) & (on == None): on = list(set(self.names) & set(df.names)) - return super().join(df, left_on, right_on, on, 'inner', suffix).pipe(from_polars) + return super().join(df, on, 'inner', left_on = left_on, right_on= right_on, suffix= suffix).pipe(from_polars) def left_join(self, df, left_on = None, right_on = None, on = None, suffix = '_right'): """ @@ -372,7 +372,7 @@ def left_join(self, df, left_on = None, right_on = None, on = None, suffix = '_r """ if (left_on == None) & (right_on == None) & (on == None): on = list(set(self.names) & set(df.names)) - return super().join(df, left_on, right_on, on, 'left', suffix).pipe(from_polars) + return super().join(df, on, 'left', left_on = left_on, right_on= right_on, suffix= suffix).pipe(from_polars) def mutate(self, *args, by = None, @@ -465,7 +465,7 @@ def full_join(self, df, left_on = None, right_on = None, on = None, suffix: str """ if (left_on == None) & (right_on == None) & (on == None): on = list(set(self.names) & set(df.names)) - return super().join(df, left_on, right_on, on, 'outer', suffix).pipe(from_polars) + return super().join(df, on, 'outer', left_on = left_on, right_on= right_on, suffix= suffix).pipe(from_polars) def pivot_longer(self, cols = everything(), From 9894941c00b497c6f2608832ac1c94908d8982d9 Mon Sep 17 00:00:00 2001 From: Maxime Rivest Date: Mon, 5 Feb 2024 15:24:01 -0500 Subject: [PATCH 2/3] change to_parquet for write_parquet --- tidypolars/tibble.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tidypolars/tibble.py b/tidypolars/tibble.py index 0a28be5..d9bc3c3 100644 --- a/tidypolars/tibble.py +++ b/tidypolars/tibble.py @@ -948,7 +948,7 @@ def write_parquet(self, use_pyarrow = False, **kwargs): """Write a data frame to a parquet""" - return super().to_parquet(file, compression, use_pyarrow, **kwargs) + return super().write_parquet(file, compression, use_pyarrow, **kwargs) def desc(x): """Mark a column to order in descending""" From b35fa96f98e75c8b669ef7017ca2f355dc45cc34 Mon Sep 17 00:00:00 2001 From: Maxime Rivest Date: Tue, 6 Feb 2024 07:25:16 -0500 Subject: [PATCH 3/3] fix to_ for write_ and fix parameters --- tidypolars/tibble.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tidypolars/tibble.py b/tidypolars/tibble.py index d9bc3c3..7acdf1f 100644 --- a/tidypolars/tibble.py +++ b/tidypolars/tibble.py @@ -940,7 +940,7 @@ def write_csv(self, has_headers = True, sep = ','): """Write a data frame to a csv""" - return super().to_csv(file, has_headers, sep) + return super().write_csv(file, include_header = has_headers, separator = sep) def write_parquet(self, file = str, @@ -948,7 +948,7 @@ def write_parquet(self, use_pyarrow = False, **kwargs): """Write a data frame to a parquet""" - return super().write_parquet(file, compression, use_pyarrow, **kwargs) + return super().write_parquet(file, compression = compression, use_pyarrow = use_pyarrow, **kwargs) def desc(x): """Mark a column to order in descending"""