✨ Improve Animator copying (createAnimatorWithAnimationsFrom
) by avoiding our patch
#47
Labels
createAnimatorWithAnimationsFrom
) by avoiding our patch
#47
We currently have a patch that allows the user to use animations from a different entity.
react-native-filament/package/cpp/core/FilamentAssetWrapper.cpp
Lines 44 to 53 in 4c37b70
For example, Entity A has 30 animations, Entity B has 0 animations, with our patch (``) you can use all of Entity A's 30 animations on Entity B.
The implementation of the patch is a bit rough as we just create a new
Animator*
pointer - which seems to work fine even in production, but we wanted to avoid the use of a patch in Filament for multiple reasons:We already created an issue in google/filament and are hoping to find a solution that can be merged upstream there: google/filament#7622
The text was updated successfully, but these errors were encountered: