Crash if length of children changes

[milesegan]

Description
The LazyIndexedStack can crash if the length of children changes.

Steps To Reproduce

1. Render the widget.
2. Change the length of children and then change the index to point to one of the new children.
3. The widget will crash trying to index past the end of the _activatedChildren list.

lazy_indexed_stack/lib/src/flutter_lazy_indexed_stack.dart

Line 37 in 0d15617

late final List<bool> _activatedChildren;

Maybe it would be safer to use a set like this:

  late final _activatedChildren = <int>{widget.index};

Thanks for the library by the way!

[marcossevilla]

hi @milesegan! I will look into this but I was curious what was the use case that generated this issue, like why did you change the length of the children and then pointed to one that wasn't on the list? This would help me understand better how the API should solve your issue without breaking changes 👍

[milesegan]

@marcossevilla In my case I have a responsive app that has a different number of items depending on whether it's on a small or a large screen. So when the user resizes the app from small to large the number of items in the stack increases. Maybe this is an unusual situation?

In any case I think you could make this change to the implementation without changing anything in the API of LazyIndexedStack.

[marcossevilla]

@milesegan sorry for the late reply, I can try reassigning the children on didUpdateWidget if they change but this would reset the stack active children. would that be the behavior you're expecting?

[milesegan]

@marcossevilla Thanks for the reply. I've been using a patched version of the stack storing them in a set instead of a list like this:

  late final _activatedChildren = <int>{widget.index};

This has been working well for me for a while now.

[marcossevilla]

@milesegan alright, you feel that should be the way it's handled in the package? I don't really see advantages aside from your use case.

[milesegan]

Well I think the main issue with the current implementation is that it's quite easy to crash the app.