Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to translate CooperativeGesturesHandler on the fly #5307

Open
wimpie3 opened this issue Jan 7, 2025 · 3 comments
Open
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed

Comments

@wimpie3
Copy link

wimpie3 commented Jan 7, 2025

User Story

As a programmer, I'd like to specify translations on the fly for the CooperativeGesturesHandler (and possibly many other locale options too).

Rationale

Currently the locale option can be specified when constructing the map, but the localized texts cannot be changed on the fly afterwards with javascript. There is no API to do so.

Impact

When this isn't added, maps will never be translatable on the fly.

@HarelM
Copy link
Collaborator

HarelM commented Jan 7, 2025

This is a large effort to do for a library without a state management system, feel free try and tackle this...

@HarelM HarelM added enhancement New feature or request PR is more than welcomed Extra attention is needed labels Jan 7, 2025
@wimpie3
Copy link
Author

wimpie3 commented Jan 7, 2025

This is a large effort to do for a library without a state management system, feel free try and tackle this...

Well, unfortunately this worked without any issues in 3.6.2, with map.setCooperativeGestures...

@HarelM
Copy link
Collaborator

HarelM commented Jan 7, 2025

This is because it wasn't using the right infrastructure...
The large effort I meant was to add this capability to the entire locale infrastructure.
For cooperative gesture there might be a simpler solution, you'll need to check...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants