Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure released Mantid version uses a specific released MSlice version #38628

Open
SilkeSchomann opened this issue Jan 21, 2025 · 1 comment · May be fixed by #38674
Open

Ensure released Mantid version uses a specific released MSlice version #38628

SilkeSchomann opened this issue Jan 21, 2025 · 1 comment · May be fixed by #38674
Assignees
@thomashampson @SilkeSchomann
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Milestone
Release 6.12

Comments

@SilkeSchomann
Copy link
Contributor

Currently, a Mantid nightly uses the current MSlice nightly. This is acceptable, as these versions are not fully tested by design. However, a released version of Mantid always needs to use a specific released version of MSlice. I thought a pin in the conda recipe would ensure this, but apparently not. Until the release of 6.12 we need to find a way to ensure this.
@SilkeSchomann SilkeSchomann added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Jan 21, 2025
@SilkeSchomann SilkeSchomann added this to the Release 6.12 milestone Jan 21, 2025
@sf1919 sf1919 moved this to Assigned in v6.12 release Jan 21, 2025
@sf1919 sf1919 mentioned this issue Jan 21, 2025
Closed
@thomashampson
Copy link
Contributor

The standalone installers will only be able to pick up an mslice version from the main label, because of this line (and the equivalent ones in the macOS and Linux standalone packaging sripts)

mantid/installers/conda/win/create_package.sh

Line 77 in 893609a

--copy --channel $CONDA_CHANNEL --channel conda-forge --channel mantid -y \

It seems like we need to satisfy the following:

  • release versions of the conda package mantidworkbench must pin exactly the mslice version, and that version must be on the main label
  • release versions of the standalone packages must also be installed with exactly the same mslice version
  • nightly/unstable versions of the standalone packages should be able to pick up mslice versions on the nightly label consistently with the conda package mantidworkbench

I think this can be achieved by keeping the mslice pin up to date in the mantidworkbench conda recipe in conjunction with checking the package suffix in the standalone packaging scripts.

@thomashampson thomashampson linked a pull request Jan 22, 2025 that will close this issue
Draft
@sf1919 sf1919 linked a pull request Jan 23, 2025 that will close this issue
Enable nightly standalone packages to install mslice nightly versions #38674
Draft
@sf1919 sf1919 moved this from Assigned to In Progress in v6.12 release Jan 23, 2025
@sf1919 sf1919 moved this from In Progress to Ready for Review in v6.12 release Jan 23, 2025
@sf1919 sf1919 moved this from Ready for Review to In Progress in v6.12 release Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomashampson thomashampson

@SilkeSchomann SilkeSchomann

Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
ISIS Core
Status: No status
v6.12 release
Status: In Progress
Milestone
Release 6.12
Development

Successfully merging a pull request may close this issue.

Enable nightly standalone packages to install mslice nightly versions mantidproject/mantid
3 participants
@thomashampson @SilkeSchomann @jclarkeSTFC