EachFriend faint triggers activated by enemy faints as well

[michaelgtuttle]

Enemy faints appear to be triggering the faint abilities of sharks and flies. Below test causes a zombie fly to spawn after enemy otter faints:

from sapai.pets import Pet
from sapai.teams import Team
from sapai.battle import Battle

team0 = Team(["fly"])
team1 = Team(["otter", "shark"])

battle = Battle(team0,team1)
winner = battle.battle()
for key, value in battle.battle_history.items():
    print(f'{key}')
    print(f'{value}')
print(winner)

This test causes an error as sharks try to apply feint triggers

from sapai.pets import Pet
from sapai.teams import Team
from sapai.battle import Battle

team0 = Team(["shark"])
team1 = Team(["shark"])

battle = Battle(team0,team1)
winner = battle.battle()

[michaelgtuttle]

should be solvable by adding the check if self.team != trigger.team: in the pets faint trigger

[manny405]

This has been fixed in the the newest branch loop_effect_queue.

For fly case you can see tests for behavior here:

sapai/tests/test_effect_queue.py

Line 117 in d03f7a6

def test_badger_honey_fly_sob(self):

For shark case you can see tests for behavior here:

sapai/tests/test_effect_queue.py

Line 164 in d03f7a6

def test_badger_honey_fly_shark_sob(self):

I am still working on some final test cases for #83. If you are interested in contributing, the remaining test cases start here:

sapai/tests/test_effect_queue.py

Line 479 in d03f7a6

def test_crab(self):

.