Fix for Issue #640 - config.xml misformatted #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ana06
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
It seems I broke this file in #638, breaking FLARE-VM 🙈 I used addlicense to add the headers and it seems a <feff> (Byte Order Mark (BOM)) in this file caused that it added the header in the wrong way, breaking the file. I am not sure if this a bug in addlicense as the BOM likely shouldn't be there, as I also think it is not needed. In any case, @tGecko thanks for reporting and fixing the bug! 💐 @Saad-Alaref thank for confirming the fix work and the additional details 💐
|
Hi @Ana06, It was a bug in Addlicence - I have created a PR to fix it. Maybe you might have more traction getting someone in Google to take a look at it because it hasn't been updated in 2.5 years |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<?xmlFixes #640
CLA has been signed.