Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Google Chrome Updates #821

Open
Ana06 opened this issue Jan 11, 2024 · 2 comments
Open

Disable Google Chrome Updates #821

Ana06 opened this issue Jan 11, 2024 · 2 comments
Labels
❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented Jan 11, 2024

Details

@binjo has proposed a way to disable Google Chrome Updates in #779 using code from https://github.com/actions/runner-images licenses under MIT @mandiant/flare-vm is this something we want to do? Does anyone has any concern with possible side-effects? Should we consider adding this as a separate packageconfig.chrome.disableupdates as proposed in #16?
@Ana06 Ana06 added the ❔ discussion Further discussion is needed label Jan 11, 2024
@Ana06 Ana06 mentioned this issue Jan 11, 2024
Closed
@Ana06
Copy link
Member Author

Ana06 commented Jan 11, 2024

We should check with legal how to best link the MIT license if we decide to include https://github.com/actions/runner-images

This was referenced Jan 11, 2024
Merged
Closed
@binjo
Copy link
Contributor

binjo commented Jan 12, 2024

The license file includes the following, which indeed we'd need to consult with legals

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❔ discussion Further discussion is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binjo @Ana06