You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Write-Output"Intel processor detected for hashcat."
} else {
Write-Output"Non-Intel processor detected. Hashcat will not work"
throw"Non-Intel processor detected."
}
However, the GitHub actions to test installation may use non-GenuineIntel processors and the package will fail. Since we cannot guarantee the processor type during the test installation, I propose we complete the installation and raise a warning to the user that their system does not support this tool due to a non-GenuineIntel processor.
This allows the test suite to recognize a successful installation and will reduce confusion as to why the package is failing.
@mandiant/commando-vm thoughts since this is mainly a Commando VM tool?
The text was updated successfully, but these errors were encountered:
I'm thinking it through some more. I'm not sure we should preform a check -- simply install and let the user find out afterwards when they execute it that it fails. My thought process is that even if we generate a warning, the user will likely not see it (esp. in headless mode).
The hashcat package will fail if the system's processor is not "GenuineIntel", see below:
VM-Packages/packages/hashcat.vm/tools/chocolateyinstall.ps1
Lines 20 to 26 in eac039d
However, the GitHub actions to test installation may use non-GenuineIntel processors and the package will fail. Since we cannot guarantee the processor type during the test installation, I propose we complete the installation and raise a warning to the user that their system does not support this tool due to a non-GenuineIntel processor.
This allows the test suite to recognize a successful installation and will reduce confusion as to why the package is failing.
@mandiant/commando-vm thoughts since this is mainly a Commando VM tool?
The text was updated successfully, but these errors were encountered: