Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete timed-out RPC callbacks #3

Open
romansavrulin opened this issue Jul 29, 2015 · 0 comments
Open

Delete timed-out RPC callbacks #3

romansavrulin opened this issue Jul 29, 2015 · 0 comments

Comments

@romansavrulin
Copy link
Contributor

As for current version, I see that callbacks are removed from JsonRpcPrivate::m_callbacks only when response with the same ID is recieved. This may lead to memory leak, especially when remote party fails to process a request for some reason (network issues/data loss, reboot, logic error, etc...).

The solution can be to implement a timeout mechanism and event reporting (e.g. callback) to free JsonRpcPrivate::m_callbacks and report this case to caller.
@romansavrulin romansavrulin changed the title Delete timed-out callbacks for RPC Delete timed-out RPC callbacks Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romansavrulin