-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Buffer
with Uint8Array
#72
Comments
I think |
ArrayBuffer
to avoid Node dependencyBuffer
with Uint8Array
@silverwind @mafintosh It seems like a fair bit of work was put into this fork: https://github.com/dnsquery/dns-packet What are the views of current maintainers for this approach? Is the preference to solely swap |
UInt8Array will be a breaking change, so I guess it might make sense to bundle a switch to TS with it. I'm not much of a TS aficionado, but I guess I should manage to review if you keep it simple. |
you can switch it to use holepunchto/b4a, we use that for easy browser compat |
Currently, this library cannot directly be used in non-Node environments (without
Buffer
polyfills). Are there any issues with switching toArrayBuffer
instead? Just wondering if such a contribution would be accepted.The text was updated successfully, but these errors were encountered: