Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maester - Teams Tests - Fixes #569

Open
merill opened this issue Dec 10, 2024 · 3 comments
Open

Maester - Teams Tests - Fixes #569

merill opened this issue Dec 10, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed teams Microsoft Teams

Comments

@merill
Copy link
Contributor

merill commented Dec 10, 2024

This issue is to track the updates planned for the Maester - Teams tests cc @weyCC81

  1. Move each test into Maester cmdlets
  2. Provider a reference number for each test e.g. MT1xxx (like we do with the other Maester tests)
  3. Include the reference number as a tag
  4. Improve the markdown to give guidance on the steps to get to the blade to make the change (including the descriptive label) and the Recommended Action step.
@merill merill added the enhancement New feature or request label Dec 10, 2024
@soulemike soulemike mentioned this issue Dec 10, 2024
6 tasks
@merill
Copy link
Contributor Author

merill commented Dec 10, 2024

@weyCC81 I've added references and updated the first Teams test as a template.

  • Added Test-MtTeamsRestrictParticipantGiveRequestControl
  • Added .md file
  • Instructions on how to fix

Would you be able to update the rest of the tests to follow the format.

PS: A future enhancement would be to add the Teams related CIS tests. Maybe @NZLostboy has thoughts. I think some of these are very similar.

@NZLostboy
Copy link
Contributor

@merill Yeah absolutely, sorry crazy end to the year and I haven't had time to finish the CIS checks.

I have some time put aside after next week to power through and finish all the CIS checks. Where we can combine the Teams tests into one test that makes total sense, but I am trying to keep the CIS tests representative of the documentation where possible so its a balance. Caching them where we can would be the bare minimum, so we can definitely achieve that.

I can pick up the state end next week when things settle down and get stuck in. Happy to collaborate here or Discord to work together on this

@merill
Copy link
Contributor Author

merill commented Dec 11, 2024

Agree, we do need to keep the rules isolated so the CIS ones can track against the CIS definitions.

I would want to avoid adding the same test to the Maester core tests if they are a simple dup.

@merill merill changed the title Maester - Teams Tests - Fixes Maester - Teams/Exchange Tests - Fixes Dec 14, 2024
@merill merill added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Dec 14, 2024
@merill merill changed the title Maester - Teams/Exchange Tests - Fixes Maester - Teams Tests - Fixes Dec 14, 2024
@merill merill added the teams Microsoft Teams label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed teams Microsoft Teams
Projects
None yet
Development

No branches or pull requests

2 participants