Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

When updating electron from upstream, revert 7ca2bb5f9ccbbfd #9

Open
chase opened this issue Nov 8, 2022 · 1 comment
Open

When updating electron from upstream, revert 7ca2bb5f9ccbbfd #9

chase opened this issue Nov 8, 2022 · 1 comment

Comments

@chase
Copy link
Contributor

chase commented Nov 8, 2022

See:
electron/electron@7ca2bb5

We tag our releases automatically based on the file, and although it introduces additional commits, the original approach is far more beneficial for us.

@chase
Copy link
Contributor Author

chase commented Jan 11, 2023

Another solution is to simply change script/lib/get-version.js to spit out the contents based on the file as before and leave everything else alone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant