Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Edit room info #30

Open
Hammyboo opened this issue Dec 3, 2021 · 2 comments
Open

[Feature] Edit room info #30

Hammyboo opened this issue Dec 3, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Hammyboo
Copy link

Hammyboo commented Dec 3, 2021

Such as, room's name, user's password, admin's password and max connection.
is that possible?

@m1k1o
Copy link
Owner

m1k1o commented Dec 3, 2021

Once container has been created, its environment variables cannot be changed. I think, that is limitation by docker.

  • Although, the container could be recreated with the same variables, but that would mean completly losing its state.
  • It could be though commited to a image and then new image recreated from that. But that might be ineffective and take a long time.
  • Or alternative would be moving configuration from envs to config file that could be dynamically modified.

UDPATE: max connection wound mean adding new ports to a container, what it again limitation by docker.

@alectrocute
Copy link

Or alternative would be moving configuration from envs to config file that could be dynamically modified.

IMHO this seems to be the best solution. Would be a good feature PR someday!

@m1k1o m1k1o changed the title Edit info [Feature] Edit room info Jan 7, 2022
@m1k1o m1k1o added the enhancement New feature or request label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants