experiments: add state cleanup for deleted experiments #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Agbuya <[email protected]>
Comment on lines
+717
to
+718
| if expurl in self.open_experiments: | ||
| self.open_experiments[expurl].close() |
There was a problem hiding this comment.
Why would you delete the state of an experiment if it's open?
There was a problem hiding this comment.
And this code is likely never called? See:
def restore_state(self, state):
if self.open_experiments:
raise NotImplementedError
...
|
The logic of this seems broken at several levels. Experiments open outside the repos are never cleared. The fact that the cleanup only happens in Limiting the size of the relevant dictionaries by removing out old entries when a certain size is reached (see https://www.google.com/search?q=python+lru+dict) sounds simpler and more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIQ Pull Request
Description of Changes
Add
cleanup_statemethod to handle stale repository experiments and prevent state accumulation. Ensures proper cleanup of submission scheduling, options, arguments and UI states when repository experiments are deleted.NOTE: Requires merging #2590 first.
Related Issue
Closes #2576
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
git commit --signoff, see copyright).Code Changes
Git Logistics
git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.git show). Format:Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.