-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LXQtTranslateDesktop.cmake
doesn't support yet the freedesktop reverse DNS files naming convention
#87
Comments
If we would decide to follow the specs for (at least) the application desktop files (Qps, LXImage-qt, QTerminal, LXQt-archiver, Screengrab and PCmanFM-qt) resolving this issue is mandatory. Example: One advantage would be that LXQt applications are grouped together. |
I made a test (without underscore) for Qps lxqt/qps#440
Edit: I had a patch installed for build-tools - it doesn't build the translations indeed so this issue is valid if we want to move to the standard. |
It's almost described in this spec page, but it's not clear if snake_case instead CamelCase is tolerated:
I use snake_case instead CamelCase, at least I saw other well known applications using it, but still not sure if it's some KDE/Gnome exception. About dashes and underscores:
|
General discussion about the format to use: lxqt/lxqt#2448 |
From the version 1.2 of the freedesktop' desktop entry specification, a File naming section was added, to define a convention by using a reversed DNS form. This is also used by AppStream and implemented on some software. Until now I personally tested it only with AppImage, but still using it for my applications.
Unfortunately LXQtTranslateDesktop.cmake doesn't support this, but just gave for grant that the first part of the filename is the name of the translation to process.
Expected Behavior
The module should find a way to extract the correct part of the filename to build the final YAML filename to pass to
LXQtTranslateDesktopYaml.pl
to be processed and so inserted in the resulting desktop file.Current Behavior
Said above, it extract the first "token" of the name, e.g.:
lx-image.desktop
=>lx-image
Possible Solution
Possibly by just prepend the country code to
.desktop.yaml
(
appname_it.desktop.yaml
andtld.domain.appname_it.desktop.yaml
).See here, though not much elegant changes.
Steps to Reproduce (for bugs)
on line 74 the result is passed to the perl script with a
${_fileName}[_.]*${_fileExt}.yaml
,e.g.:
lx-image_it.desktop.yaml
The same process using
org.mydomain.myappname.desktop.in
results in aorg_it.mydomain.myappname.desktop.yaml
instead oforg.mydomain.myappname_it.desktop.yaml
Context
See above.
System Information
Irrelevant.
The text was updated successfully, but these errors were encountered: