Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package does not contain distribution #1

Open
jochenberger opened this issue Nov 4, 2015 · 6 comments
Open

NPM package does not contain distribution #1

jochenberger opened this issue Nov 4, 2015 · 6 comments

Comments

@jochenberger
Copy link

$ npm install react-jstree
[email protected] node_modules/react-jstree
├── [email protected]
└── [email protected] ([email protected], [email protected])
$ ls node_modules/react-jstree/
config.js  gulpfile.js  node_modules  package.json  README.md  src
$ ls node_modules/react-jstree/src/
index.js
$ cat node_modules/react-jstree/src/index.js 
$

The dist directory is missing from the package and src/index.js is empty.

@luqin
Copy link
Owner

luqin commented Nov 5, 2015

@jochenberger
Yes. Because I have not implement any feafure in this repo. I'm think about how to rewrite jstree components or wrap jstree with react. Do you have any idea?

@jochenberger
Copy link
Author

Wrapping might be hard when it comes to updating an existing tree. jsTree does not preserve the data-react-id on ul elements (vakata/jstree#1271) and React chokes on that pretty hard. And I'm not aware of a proper API call that updates an existing tree with new data.
You could diff the JSON manually and convert it into proper API calls on the jsTree instance, but it might be easier to do a full rewrite.

@conor909
Copy link

conor909 commented Dec 9, 2015

This repo would be great. Is there plans for it to be developed and maintained further?

@Data-Meister
Copy link

OH! Is this not working at all yet?

@luqin
Copy link
Owner

luqin commented Dec 17, 2015

@Data-Meister Congratulations,you got it

@stonecharioteer
Copy link

@luqin Hey, did you make any progress with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants