Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugins.api into separate module #216

Closed
notjuanortiz opened this issue Mar 6, 2020 · 3 comments
Closed

Move plugins.api into separate module #216

notjuanortiz opened this issue Mar 6, 2020 · 3 comments
Labels
average An issue that is neither hard nor easy to resolve. high priority An issue that should be resolved right away.

Comments

@notjuanortiz
Copy link
Contributor

Problem

The plugins folder contains the API as well as kotlin plugins. By moving the API (we should rename this) into a separate module, this would contribute to #155

Implementation

Create gradle module api with a dependency on the rootProject and kotlin.
Move api package from plugins folder into src/main/kotlin within the api module.

@lare96 lare96 added high priority An issue that should be resolved right away. medium priority An issue that can be resolved whenever, but is guaranteed to be completed. average An issue that is neither hard nor easy to resolve. and removed medium priority An issue that can be resolved whenever, but is guaranteed to be completed. labels Mar 15, 2020
@lare96
Copy link
Member

lare96 commented Mar 15, 2020

What do you suggest it be named other than API? I think that should be decided on before going forward

@notjuanortiz
Copy link
Contributor Author

If the purpose of the library is to build on top of the existing infrastructure without exposing critical components like networking or the game loop, I think SDK (Software Development Kit) is a more appropriate term.

Here's some examples of existing plugin SDKs (not necessarily related to game development)

@lare96
Copy link
Member

lare96 commented Mar 19, 2020

Merge with #180

@lare96 lare96 closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
average An issue that is neither hard nor easy to resolve. high priority An issue that should be resolved right away.
Projects
None yet
Development

No branches or pull requests

2 participants