Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System for storing/retrieving npc drops #192

Open
notjuanortiz opened this issue Dec 14, 2019 · 3 comments
Open

System for storing/retrieving npc drops #192

notjuanortiz opened this issue Dec 14, 2019 · 3 comments
Labels
core-java An issue related to the core Java source code. plugin-kotlin An issue related to the plugin Kotlin source code.
Milestone

Comments

@notjuanortiz
Copy link
Contributor

The fields that need to be stored are:

  • Npc id
  • Item id
  • Item amount

We should consider support for drop table sharing, where multiple Npcs share the same item drop data. For example, Giant spiders have three different ids, each with a different combat level, but all share the same drop data.

As well, we should support item amount randomization, where we have a minimum and maximum range of items dropped for single a drop entry.

@lare96 lare96 added this to the v1.0 milestone Jan 5, 2020
@stale stale bot added the wontfix label Mar 5, 2020
@stale stale bot closed this as completed Mar 12, 2020
@luna-rs luna-rs deleted a comment from stale bot Mar 15, 2020
@luna-rs luna-rs deleted a comment from stale bot Mar 15, 2020
@lare96 lare96 reopened this Mar 15, 2020
@stale stale bot removed the wontfix label Mar 15, 2020
@lare96 lare96 added low priority urgent An issue that needs to be fixed urgently because it impacts core functionality. and removed medium priority labels Mar 15, 2020
@stale
Copy link

stale bot commented May 14, 2020

This issue has been marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label May 14, 2020
@stale
Copy link

stale bot commented May 21, 2020

This issue has been closed because it has not had any recent activity. Feel free to re-open this issue or create another one if the problem isn't resolved.

@stale stale bot closed this as completed May 21, 2020
@lare96 lare96 removed the wontfix label Dec 28, 2020
@lare96 lare96 reopened this Dec 28, 2020
@lare96 lare96 removed low priority urgent An issue that needs to be fixed urgently because it impacts core functionality. labels Jan 25, 2025
@lare96
Copy link
Member

lare96 commented Jan 26, 2025

Drop table instances can already be created so there's that out of the way. The second issue is just creating a system for linking those tables to certain attributes of an NPC.

These could be drop tables linked to NPCs by

  • NPC ID
npcDrop(1) {
    val tables = ... ;// Create table(s)
    return NpcDropTableSet(tables)
}
  • NPC instance
val npc = ...;

npc.dropTable = NpcDropTableSet(DropTables.MY_TABLES)

@lare96 lare96 added core-java An issue related to the core Java source code. plugin-kotlin An issue related to the plugin Kotlin source code. labels Jan 26, 2025
@lare96 lare96 modified the milestone: v1.0 Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-java An issue related to the core Java source code. plugin-kotlin An issue related to the plugin Kotlin source code.
Projects
None yet
Development

No branches or pull requests

2 participants