From f9a96dc829896e26fc77f31933559bbc830b3541 Mon Sep 17 00:00:00 2001 From: Bruno Henriques Date: Tue, 7 Jan 2025 10:53:44 +0000 Subject: [PATCH] chore(types): remove indiscriminate root path imports - IDEs shoud no longer suggest invalid packages/* imports --- {docs/tests => .storybook}/utils.ts | 0 .../src/stories/Components.test.stories.tsx | 96 +++++++++---------- .../IconContainer.stories.tsx | 0 .../core/src/stories/Widgets.test.stories.tsx | 28 +++--- .../lab/src/stories/Lab.test.stories.tsx | 10 +- .../src/stories/Pentaho.test.stories.tsx | 6 +- tsconfig.build.json | 1 - tsconfig.json | 1 + 8 files changed, 71 insertions(+), 71 deletions(-) rename {docs/tests => .storybook}/utils.ts (100%) rename docs/tests/Components.stories.tsx => packages/core/src/stories/Components.test.stories.tsx (69%) rename packages/core/src/{IconContainer => stories}/IconContainer.stories.tsx (100%) rename docs/tests/Widgets.stories.tsx => packages/core/src/stories/Widgets.test.stories.tsx (75%) rename docs/tests/Lab.stories.tsx => packages/lab/src/stories/Lab.test.stories.tsx (73%) rename docs/tests/Pentaho.stories.tsx => packages/pentaho/src/stories/Pentaho.test.stories.tsx (77%) diff --git a/docs/tests/utils.ts b/.storybook/utils.ts similarity index 100% rename from docs/tests/utils.ts rename to .storybook/utils.ts diff --git a/docs/tests/Components.stories.tsx b/packages/core/src/stories/Components.test.stories.tsx similarity index 69% rename from docs/tests/Components.stories.tsx rename to packages/core/src/stories/Components.test.stories.tsx index 3e5099c4a7..fbc1253231 100644 --- a/docs/tests/Components.stories.tsx +++ b/packages/core/src/stories/Components.test.stories.tsx @@ -1,63 +1,63 @@ import { Meta, StoryObj } from "@storybook/react"; import { userEvent, within } from "@storybook/test"; -import { HvSimpleGrid } from "packages/core"; -import { Disabled as AccordionDisabledStory } from "packages/core/src/Accordion/Accordion.stories"; -import { Test as AvatarTestStory } from "packages/core/src/Avatar/Avatar.stories"; -import { Test as AvatarGroupTestStory } from "packages/core/src/AvatarGroup/stories/AvatarGroup.stories"; -import { Test as BadgeTestStory } from "packages/core/src/Badge/Badge.stories"; -import { Variants as BannerVariantsStory } from "packages/core/src/Banner/Banner.stories"; -import { Test as ButtonTestStory } from "packages/core/src/Button/Button.stories"; -import { Variants as CardVariantsStory } from "packages/core/src/Card/Card.stories"; -import { Test as CheckBoxTestStory } from "packages/core/src/CheckBox/CheckBox.stories"; -import { Variants as CheckBoxGroupVariantsStory } from "packages/core/src/CheckBoxGroup/CheckBoxGroup.stories"; -import { Main as ContainerMainStory } from "packages/core/src/Container/Container.stories"; -import { Test as DatePickerTestStory } from "packages/core/src/DatePicker/DatePicker.stories"; -import { Main as DotPaginationMainStory } from "packages/core/src/DotPagination/DotPagination.stories"; -import { Test as DropdownTestStory } from "packages/core/src/Dropdown/stories/Dropdown.stories"; -import { Main as DropDownMenuMainStory } from "packages/core/src/DropDownMenu/DropDownMenu.stories"; + +import { Disabled as AccordionDisabledStory } from "../Accordion/Accordion.stories"; +import { Test as AvatarTestStory } from "../Avatar/Avatar.stories"; +import { Test as AvatarGroupTestStory } from "../AvatarGroup/stories/AvatarGroup.stories"; +import { Test as BadgeTestStory } from "../Badge/Badge.stories"; +import { Variants as BannerVariantsStory } from "../Banner/Banner.stories"; +import { Test as ButtonTestStory } from "../Button/Button.stories"; +import { Variants as CardVariantsStory } from "../Card/Card.stories"; +import { Test as CheckBoxTestStory } from "../CheckBox/CheckBox.stories"; +import { Variants as CheckBoxGroupVariantsStory } from "../CheckBoxGroup/CheckBoxGroup.stories"; +import { Main as ContainerMainStory } from "../Container/Container.stories"; +import { Test as DatePickerTestStory } from "../DatePicker/DatePicker.stories"; +import { Main as DotPaginationMainStory } from "../DotPagination/DotPagination.stories"; +import { Test as DropdownTestStory } from "../Dropdown/stories/Dropdown.stories"; +import { Main as DropDownMenuMainStory } from "../DropDownMenu/DropDownMenu.stories"; import { Minimal as EmptyStateMinimalStory, WithAction as EmptyStateWithActionStory, -} from "packages/core/src/EmptyState/EmptyState.stories"; -import { TheDesignSystemColumns as GridTheDesignSystemColumnsStory } from "packages/core/src/Grid/Grid.stories"; -import { Variants as IconButtonVariantsStory } from "packages/core/src/IconButton/IconButton.stories"; -import { Test as InlineEditorTestStory } from "packages/core/src/InlineEditor/InlineEditor.stories"; -import { Test as InputTestStory } from "packages/core/src/Input/Input.stories"; -import { Main as KpiMainStory } from "packages/core/src/Kpi/Kpi.stories"; -import { WithIcons as ListContainerWithIconsStory } from "packages/core/src/ListContainer/ListContainer.stories"; -import { Variants as LoadingVariantsStory } from "packages/core/src/Loading/Loading.stories"; -import { Test as MultiButtonTestStory } from "packages/core/src/MultiButton/stories/MultiButton.stories"; -import { Main as OverflowTooltipMainStory } from "packages/core/src/OverflowTooltip/OverflowTooltip.stories"; -import { Main as PaginationMainStory } from "packages/core/src/Pagination/Pagination.stories"; -import { Main as PanelMainStory } from "packages/core/src/Panel/Panel.stories"; -import { Variants as ProgressBarVariantsStory } from "packages/core/src/ProgressBar/ProgressBar.stories"; -import { Test as RadioTestStory } from "packages/core/src/Radio/Radio.stories"; +} from "../EmptyState/EmptyState.stories"; +import { TheDesignSystemColumns as GridTheDesignSystemColumnsStory } from "../Grid/Grid.stories"; +import { Variants as IconButtonVariantsStory } from "../IconButton/IconButton.stories"; +import { Test as InlineEditorTestStory } from "../InlineEditor/InlineEditor.stories"; +import { Test as InputTestStory } from "../Input/Input.stories"; +import { Main as KpiMainStory } from "../Kpi/Kpi.stories"; +import { WithIcons as ListContainerWithIconsStory } from "../ListContainer/ListContainer.stories"; +import { Variants as LoadingVariantsStory } from "../Loading/Loading.stories"; +import { Test as MultiButtonTestStory } from "../MultiButton/stories/MultiButton.stories"; +import { Main as OverflowTooltipMainStory } from "../OverflowTooltip/OverflowTooltip.stories"; +import { Main as PaginationMainStory } from "../Pagination/Pagination.stories"; +import { Main as PanelMainStory } from "../Panel/Panel.stories"; +import { Variants as ProgressBarVariantsStory } from "../ProgressBar/ProgressBar.stories"; +import { Test as RadioTestStory } from "../Radio/Radio.stories"; import { Horizontal as RadioGroupHorizontalStory, Variants as RadioGroupVariantsStory, -} from "packages/core/src/RadioGroup/RadioGroup.stories"; -import { Main as ScrollToHorizontalMainStory } from "packages/core/src/ScrollTo/Horizontal/ScrollToHorizontal.stories"; -import { Main as ScrollToVerticalMainStory } from "packages/core/src/ScrollTo/Vertical/ScrollToVertical.stories"; -import { Test as SelectTestStory } from "packages/core/src/Select/Select.stories"; -import { Variants as SelectionListVariantsStory } from "packages/core/src/SelectionList/SelectionList.stories"; -import { Main as SimpleGridMainStory } from "packages/core/src/SimpleGrid/SimpleGrid.stories"; -import { Variants as SkeletonVariantsStory } from "packages/core/src/Skeleton/Skeleton.stories"; +} from "../RadioGroup/RadioGroup.stories"; +import { Main as ScrollToHorizontalMainStory } from "../ScrollTo/Horizontal/ScrollToHorizontal.stories"; +import { Main as ScrollToVerticalMainStory } from "../ScrollTo/Vertical/ScrollToVertical.stories"; +import { Test as SelectTestStory } from "../Select/Select.stories"; +import { Variants as SelectionListVariantsStory } from "../SelectionList/SelectionList.stories"; +import { HvSimpleGrid } from "../SimpleGrid"; +import { Main as SimpleGridMainStory } from "../SimpleGrid/SimpleGrid.stories"; +import { Variants as SkeletonVariantsStory } from "../Skeleton/Skeleton.stories"; import { RangeVariants as SliderRangeVariantsStory, Variants as SliderVariantsStory, -} from "packages/core/src/Slider/Slider.stories"; -import { Variants as SnackbarVariantsStory } from "packages/core/src/Snackbar/Snackbar.stories"; -import { Test as StackTestStory } from "packages/core/src/Stack/Stack.stories"; -import { Variants as SwitchVariantsStory } from "packages/core/src/Switch/Switch.stories"; -import { Test as TabsTestStory } from "packages/core/src/Tabs/Tabs.stories"; -import { Test as TagTestStory } from "packages/core/src/Tag/stories/Tag.stories"; -import { Variants as TagsInputVariantsStory } from "packages/core/src/TagsInput/TagsInput.stories"; -import { Variants as TextAreaVariantsStory } from "packages/core/src/TextArea/TextArea.stories"; -import { Multiple as ToggleButtonMultipleStory } from "packages/core/src/ToggleButton/ToggleButton.stories"; -import { Test as TypographyTestStory } from "packages/core/src/Typography/Typography.stories"; - -import { renderStory } from "./utils"; +} from "../Slider/Slider.stories"; +import { Variants as SnackbarVariantsStory } from "../Snackbar/Snackbar.stories"; +import { Test as StackTestStory } from "../Stack/Stack.stories"; +import { Variants as SwitchVariantsStory } from "../Switch/Switch.stories"; +import { Test as TabsTestStory } from "../Tabs/Tabs.stories"; +import { Test as TagTestStory } from "../Tag/stories/Tag.stories"; +import { Variants as TagsInputVariantsStory } from "../TagsInput/TagsInput.stories"; +import { Variants as TextAreaVariantsStory } from "../TextArea/TextArea.stories"; +import { Multiple as ToggleButtonMultipleStory } from "../ToggleButton/ToggleButton.stories"; +import { Test as TypographyTestStory } from "../Typography/Typography.stories"; import { setupChromatic } from ".storybook/setupChromatic"; +import { renderStory } from ".storybook/utils"; /** Visual tests for components from the Core package */ const meta: Meta = { diff --git a/packages/core/src/IconContainer/IconContainer.stories.tsx b/packages/core/src/stories/IconContainer.stories.tsx similarity index 100% rename from packages/core/src/IconContainer/IconContainer.stories.tsx rename to packages/core/src/stories/IconContainer.stories.tsx diff --git a/docs/tests/Widgets.stories.tsx b/packages/core/src/stories/Widgets.test.stories.tsx similarity index 75% rename from docs/tests/Widgets.stories.tsx rename to packages/core/src/stories/Widgets.test.stories.tsx index 068f815273..52a11f589c 100644 --- a/docs/tests/Widgets.stories.tsx +++ b/packages/core/src/stories/Widgets.test.stories.tsx @@ -1,25 +1,25 @@ import { Meta, StoryObj } from "@storybook/react"; -import { HvSimpleGrid } from "packages/core"; -import { Main as ActionBarMainStory } from "packages/core/src/ActionBar/ActionBar.stories"; + +import { Main as ActionBarMainStory } from "../ActionBar/ActionBar.stories"; import { Main as AppSwitcherMainStory, ManyEntries as AppSwitcherManyEntriesStory, -} from "packages/core/src/AppSwitcher/AppSwitcher.stories"; -import { Test as BreadCrumbTestStory } from "packages/core/src/BreadCrumb/BreadCrumb.stories"; -import { Test as BulkActionsTestStory } from "packages/core/src/BulkActions/BulkActions.stories"; +} from "../AppSwitcher/AppSwitcher.stories"; +import { Test as BreadCrumbTestStory } from "../BreadCrumb/BreadCrumb.stories"; +import { Test as BulkActionsTestStory } from "../BulkActions/BulkActions.stories"; import { Actions as CarouselActionsStory, Embedded as CarouselEmbeddedStory, -} from "packages/core/src/Carousel/Carousel.stories"; -import { Test as ColorPickerTestStory } from "packages/core/src/ColorPicker/ColorPicker.stories"; -import { WithPreviewThumbnails as FileUploaderWithPreviewThumbnailsStory } from "packages/core/src/FileUploader/FileUploader.stories"; -import { CustomLabels as FooterCustomLabelsStory } from "packages/core/src/Footer/Footer.stories"; -import { Test as GlobalActionsTestStory } from "packages/core/src/GlobalActions/GlobalActions.stories"; -import { Test as HeaderTestStory } from "packages/core/src/Header/Header.stories"; -import { Test as SectionTestStory } from "packages/core/src/Section/Section.stories"; - -import { renderStory } from "./utils"; +} from "../Carousel/Carousel.stories"; +import { Test as ColorPickerTestStory } from "../ColorPicker/ColorPicker.stories"; +import { WithPreviewThumbnails as FileUploaderWithPreviewThumbnailsStory } from "../FileUploader/FileUploader.stories"; +import { CustomLabels as FooterCustomLabelsStory } from "../Footer/Footer.stories"; +import { Test as GlobalActionsTestStory } from "../GlobalActions/GlobalActions.stories"; +import { Test as HeaderTestStory } from "../Header/Header.stories"; +import { Test as SectionTestStory } from "../Section/Section.stories"; +import { HvSimpleGrid } from "../SimpleGrid"; import { setupChromatic } from ".storybook/setupChromatic"; +import { renderStory } from ".storybook/utils"; /** Visual tests for widgets from the Core package */ const meta: Meta = { diff --git a/docs/tests/Lab.stories.tsx b/packages/lab/src/stories/Lab.test.stories.tsx similarity index 73% rename from docs/tests/Lab.stories.tsx rename to packages/lab/src/stories/Lab.test.stories.tsx index dc00f7dafc..a5a86145d5 100644 --- a/docs/tests/Lab.stories.tsx +++ b/packages/lab/src/stories/Lab.test.stories.tsx @@ -1,12 +1,12 @@ import { Meta, StoryObj } from "@storybook/react"; -import { Variants as BladeVariantsStory } from "packages/lab/src/Blade/Blade.stories"; -import { Main as BladesMainStory } from "packages/lab/src/Blades/Blades.stories"; -import { Main as DashboardMainStory } from "packages/lab/src/Dashboard/Dashboard.stories"; -import { Variants as StepNavigationVariantsStory } from "packages/lab/src/StepNavigation/StepNavigation.stories"; import { HvSimpleGrid } from "@hitachivantara/uikit-react-core"; -import { renderStory } from "./utils"; +import { Variants as BladeVariantsStory } from "../Blade/Blade.stories"; +import { Main as BladesMainStory } from "../Blades/Blades.stories"; +import { Main as DashboardMainStory } from "../Dashboard/Dashboard.stories"; +import { Variants as StepNavigationVariantsStory } from "../StepNavigation/StepNavigation.stories"; import { setupChromatic } from ".storybook/setupChromatic"; +import { renderStory } from ".storybook/utils"; /** Visual tests for components from the Lab package */ const meta: Meta = { diff --git a/docs/tests/Pentaho.stories.tsx b/packages/pentaho/src/stories/Pentaho.test.stories.tsx similarity index 77% rename from docs/tests/Pentaho.stories.tsx rename to packages/pentaho/src/stories/Pentaho.test.stories.tsx index ceb6172f1d..dc745ecaae 100644 --- a/docs/tests/Pentaho.stories.tsx +++ b/packages/pentaho/src/stories/Pentaho.test.stories.tsx @@ -1,10 +1,10 @@ import { Meta, StoryObj } from "@storybook/react"; -import { Test as BottomPanelTestStory } from "packages/pentaho/src/Canvas/BottomPanel/BottomPanel.stories"; -import { Test as ToolbarTabsTestStory } from "packages/pentaho/src/Canvas/ToolbarTabs/ToolbarTabs.stories"; import { HvSimpleGrid } from "@hitachivantara/uikit-react-core"; -import { renderStory } from "./utils"; +import { Test as BottomPanelTestStory } from "../Canvas/BottomPanel/BottomPanel.stories"; +import { Test as ToolbarTabsTestStory } from "../Canvas/ToolbarTabs/ToolbarTabs.stories"; import { setupChromatic } from ".storybook/setupChromatic"; +import { renderStory } from ".storybook/utils"; /** Visual tests for components from the Pentaho package */ const meta: Meta = { diff --git a/tsconfig.build.json b/tsconfig.build.json index 1392c7bc26..5a5d6a457b 100644 --- a/tsconfig.build.json +++ b/tsconfig.build.json @@ -26,7 +26,6 @@ /* Others */ "lib": ["es2022", "dom", "dom.iterable"], "jsx": "react-jsx", - "baseUrl": ".", "types": [ "node", "jest", diff --git a/tsconfig.json b/tsconfig.json index 1714dd850c..d2621a8d1a 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -2,6 +2,7 @@ "extends": "./tsconfig.build.json", "compilerOptions": { "paths": { + ".storybook/*": ["./.storybook/*"], "~/*": ["./apps/app/src/*"], "@docs/*": ["./apps/docs/src/*"] }