Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]Code review / refactoring / improvement #55

Open
luc-github opened this issue Jan 19, 2024 · 1 comment
Open

[FEATURE REQUEST]Code review / refactoring / improvement #55

luc-github opened this issue Jan 19, 2024 · 1 comment
Labels

Comments

@luc-github
Copy link
Owner

luc-github commented Jan 19, 2024

This is todo list of several topic that need to be done before release:

@luc-github
Copy link
Owner Author

More I read the code more I think a refactoring is mandatory

  • there are too many tasks for specific actions
    Should be one for core 0 for wifi and wifi clients (http/websockets/telnet , one for core 1 in charge of main loop (variables, async action), one for serial/usb (not wifi clients), one for lvgl rendering , one for streaming gcode
  • there are several temporary task creations/destructions which may failed if low memory and this because need to do some things async so using core task should be enough and lower the memory footprint
  • some code is redondant in several targets so need to simplify code architecture

So I will take opportunity to do it in same time as the migration to lvgl 9+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant