Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling and skipping when term not present in Wikidata #49

Open
lubianat opened this issue Oct 14, 2022 · 4 comments
Open

Improve handling and skipping when term not present in Wikidata #49

lubianat opened this issue Oct 14, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@lubianat
Copy link
Owner

Sometimes a term is not on Wikidata and we'd rather just exclude it instead of going through the effort of creating a new entry.

Not sure about how to implement:

  • special dict value ("SKIP") that is skipped?
  • flag that skips any missing when running import?
@jvfe jvfe added the enhancement New feature or request label Oct 14, 2022
@jvfe
Copy link
Collaborator

jvfe commented Oct 14, 2022

I prefer the second option. Having keys in our dict that don't refer to Q-Ids would be a big change from the current data model.
Another idea is having a third option when receiving the prompt, e.g:

Is the QID for 'Systems Biology'  
 Q815297 - systems biology (computational and mathematical modeling of complex biological systems) ? (y/n/skip)

@lubianat
Copy link
Owner Author

lubianat commented Oct 14, 2022 via email

@cthoyt
Copy link
Collaborator

cthoyt commented Oct 14, 2022

Agreed, having a skip option would be nice.

@jvfe
Copy link
Collaborator

jvfe commented Oct 15, 2022

I believe the implementation would be more appropriate inside of add_key in wdcuration.py, since that function is the one that generates the prompts to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants