-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling and skipping when term not present in Wikidata #49
Labels
enhancement
New feature or request
Comments
I prefer the second option. Having keys in our dict that don't refer to Q-Ids would be a big change from the current data model.
|
Yeah, I like this option. And one could set a general "skip" flag to just
treat all of them as skips.
Tiago
…On Fri, Oct 14, 2022 at 11:14 AM João Vitor ***@***.***> wrote:
I prefer the second option. Having keys in our dict that don't refer to
Q-Ids would be a big change from the current data model.
Another idea is having a third option when receiving the prompt, e.g:
Is the QID for 'Systems Biology'
Q815297 - systems biology (computational and mathematical modeling of complex biological systems) ? (y/n/skip)
—
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4NC7YU3FYF2VN7NKNTXRTWDFTD3ANCNFSM6AAAAAARFIY4BY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Agreed, having a skip option would be nice. |
I believe the implementation would be more appropriate inside of add_key in wdcuration.py, since that function is the one that generates the prompts to the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes a term is not on Wikidata and we'd rather just exclude it instead of going through the effort of creating a new entry.
Not sure about how to implement:
The text was updated successfully, but these errors were encountered: