-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add formatter #84
Comments
ci shouldnt be added till #15 is done |
Fair enough |
Side note, it's also possible to have actions that directly commit to the working branches of PRs. I feel this could be neat to make the process smoother. |
Yes, as long as the auto-committed code is thoroughly reviewed! Of course, that should apply to human-written code, but I think we've all had our oopsies with that. But yeah, I'm in favor of experimenting with this |
A correct formatter should not require review of its output, it should only make changes that don't change anything semantically (like converting |
In my book, any changes to any files require review--you just never know!! But yes, formatters like Prettier should be fine, but we should always review as we're responsible for ensuring the stuff we merge and deploy is good, we can never "blame the formatter" |
Prettier is nice
Why not? Wouldn't having automatic formatting make importing pages easier, since you'd have one thing less to worry about? |
Greatly reduces decision fatigue while writing documents :)
The text was updated successfully, but these errors were encountered: