The "GlobalSeed" node doesn't work with grouped nodes

[GalaxyTimeMachine]

As per the title, it has no effect on grouped nodes. Stage B in the image is a grouped node...

[muunkky]

I'm having this problem too, but not with a grouped node. I think it's a logic error in the global seed handler.

Take a look at the current version below. It iterates through all nodes and collects the values from the GlobalSeed node when it encounters it, but that means ignoring all the nodes that it passes until then because w will be undefined.

Most straightforward approach is to find the values from the global seed widget first and then iterate through the nodes

import { api } from "../../scripts/api.js";

function globalSeedHandler(event) {
	let nodes = app.graph._nodes_by_id;

	for(let i in nodes) {
		let node = nodes[i];

		if(node.type == 'GlobalSeed //Inspire') {
			if(node.widgets) {
				const w = node.widgets.find((w) => w.name == 'value');
				const last_w = node.widgets.find((w) => w.name == 'last_seed');
				last_w.value = w.value;
				if(event.detail.value != null)
					w.value = event.detail.value;
			}
		}
		else
			if(node.widgets) {
				const w = node.widgets.find((w) => (w.name == 'seed' || w.name == 'noise_seed') && w.type == 'number');
				if(w && event.detail.seed_map[node.id] != undefined) {
					w.value = event.detail.seed_map[node.id];
				}
			}
	}
}

api.addEventListener("inspire-global-seed", globalSeedHandler);

[ltdrdata]

I'm having this problem too, but not with a grouped node. I think it's a logic error in the global seed handler.

Take a look at the current version below. It iterates through all nodes and collects the values from the GlobalSeed node when it encounters it, but that means ignoring all the nodes that it passes until then because w will be undefined.

Most straightforward approach is to find the values from the global seed widget first and then iterate through the nodes

That part is simply about reflecting the workflow update information received from the backend into the workflow. The update information includes details on how to update each widget of the nodes, so the order doesn't matter.

The actual update of the seed occurs when the prompt is sent to the backend and before the prompt is executed.

ComfyUI-Inspire-Pack/inspire/inspire_server.py

Line 113 in 34de5e3

def prompt_seed_update(json_data):

[ltdrdata]

Group nodes are dynamically generated and executed in the form of virtual nodes, which is a special structure. Currently, the functions processed right before the prompt execution (global seed, onprompt, ...) do not take group nodes into account.

[muunkky]

thanks @ltdrdata. I wasn't using a group node. I'll try to replicate it and see what I find