Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello, I find a bug in your code #12

Open
GW-S opened this issue Nov 27, 2019 · 3 comments
Open

Hello, I find a bug in your code #12

GW-S opened this issue Nov 27, 2019 · 3 comments

Comments

@GW-S
Copy link

GW-S commented Nov 27, 2019

你好,我在你的代码里可能发现了一个bug.
在进过transfer处理后的train.txt文件里,我们可以看到,所有的aspect_term都是none,这样,就根本利用不到aspect的信息吧。

请问你是paper的作者本人吗……

@lpq29743
Copy link
Owner

lpq29743 commented Nov 28, 2019

谢谢你的反馈

  1. 看了一下生成的文件,确实是有这个问题,但可能一开始没有,因为我写那段代码应该是有检查的,我短期内估计安排不出时间解决这个问题,如果你有兴趣,欢迎提pull request
  2. 我非paper作者本人

@CodeStuart
Copy link

Try changing target to term on lines 23 and 27

@nicolay-r
Copy link
Contributor

nicolay-r commented Jan 10, 2020

@Shengguowei, recently i have encountered an equal weights across aspects and contexts in my experiments.
Here is a pull-request/fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants