-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade strong-globalize to the latest version #4585
Comments
@bajtos, I've updated the original description with the list of repos. I'm not sure whether we need to update for |
The following modules are in LTS modes, I am not sure if it's a good idea to update them - I am not sure about the impact of breaking changes made in strong-globalize on the consumers of those modules. Maybe we can leave them out from the first wave of upgrades?
Important: loopback-datasource-juggler is used by LB4, we need to update it. |
The latest A possible solution: upgrade the Another thing to consider: all connectors have juggler3.x as dev-dependency, which also has the engine limit as >8. |
Thank you @jannyHou for pointing out important details we should keep in consideration. Since Node.js 8.x has reached end of life in December 2019, it's perfectly fine to stop supporting in actively developed repositories (e.g. connectors) and it's probably ok to drop it from repos in LTS mode too.
+1, I agree with your proposal. While bumping up the minimal supported Node.js version, let's set it to Node.js 10.x, the oldest major version that's still maintained. |
As part of releasing a new semver-major version of the connectors, we should update LTS information README files. Move the Current version to Active LTS, the Active LTS version to Maintenance LTS, and check which Maintenance LTS versions has reached end of life. See https://loopback.io/doc/en/contrib/Long-term-support.html |
This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the |
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
In a typical application, there are multiple versions (and copies) of strong-globalize in the dependency tree.
Take our examples/todo as an example:
At the moment,
require('strong-globalize')
is taking about0.3s
(see strongloop/strong-globalize#158). Every copy of the module adds another 1/3 of a second to the application load time.Let's upgrade strong-globalize to the latest version in LB modules maintained by StrongLoop (unless they are in Active or Maintenance LTS mode).
Acceptance criteria
Figure out a solution for the node version's compatibility first, see comment Upgrade strong-globalize to the latest version #4585 (comment)
Check the following packages and update strong-globalize dependency if needed. The list is based on https://github.com/strongloop-internal/scrum-apex/issues/372:
Connectors
Others
The text was updated successfully, but these errors were encountered: