Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to search within pages section #547

Closed
cody-clio opened this issue Nov 7, 2023 · 3 comments
Closed

Ability to search within pages section #547

cody-clio opened this issue Nov 7, 2023 · 3 comments
Labels
feature request A suggestion for a feature or enhancement

Comments

@cody-clio
Copy link

Describe the solution you'd like

There is the ability to filter previews by name and would like to see the same behaviour for the pages section.
Screenshot 2023-11-07 at 3 10 45 PM

@cody-clio cody-clio added the feature request A suggestion for a feature or enhancement label Nov 7, 2023
@allmarkedup
Copy link
Collaborator

@cody-clio yes, this makes total sense. Also shouldn't be too difficult to implement unless I'm overlooking something. When I have a chance I'll have a bit of play and see if I can put something together.

@allmarkedup
Copy link
Collaborator

Just a note that I've added this functionality as part of this PR: #556 (See messages in #546 for more context.)

@allmarkedup
Copy link
Collaborator

Hey @cody-clio just a heads up that I've just released version 2.2.0 that has this functionality in it.

However I have changed the names of the config variables to enable/disable page and preview filters. The are now page_nav_filter and preview_nav_filter respectively (instead of page_search and preview_search.

I made the change because 'search' feels like too loaded a term - I didn't want people confused that this is a text search of some type. And if Lookbook has that one day then it could get confusing, so I felt the new config names were more descriptive.

Thanks again for the suggestions, I'm going to go ahead and close these issues down now but if you have any problems with the latest release just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A suggestion for a feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants