Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage with a name #114

Open
szepeviktor opened this issue Dec 29, 2024 · 7 comments · May be fixed by #115
Open

Usage with a name #114

szepeviktor opened this issue Dec 29, 2024 · 7 comments · May be fixed by #115

Comments

@szepeviktor
Copy link

Would you merge a PR that enables this kind of usage?

use Lmc\CodingStandard\Set\ECSSetList;

return ECSConfig::configure()
    ->withSets([ECSSetList::CUSTOM]);
@OndraM
Copy link
Member

OndraM commented Jan 3, 2025

Hi, this is question directly for ECS library: https://github.com/easy-coding-standard/easy-coding-standard/ . This repo is only predefined set of rules for ECS we use.

@OndraM OndraM closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
@szepeviktor
Copy link
Author

szepeviktor commented Jan 3, 2025 •
edited
Loading

@OndraM Yes, but rules in this repo cannot be used with a name only,
a file needs to be included: vendor/lmc/coding-standard/ecs.php

@OndraM
Copy link
Member

OndraM commented Jan 3, 2025

Is there any benefit of using set list instead of file import?

@szepeviktor
Copy link
Author

I need an LLM to argue.
A literal string in the source code is never a good idea.

@OndraM
Copy link
Member

OndraM commented Jan 3, 2025

Well for us change in the path would be treated like BC break - so it has basically the same effect as using the imported constant.

However, I think we can add the SetList, its not a bad idea. So can you submit the PR, please?

@OndraM OndraM reopened this Jan 3, 2025
@OndraM
Copy link
Member

OndraM commented Jan 3, 2025

@szepeviktor And please use a name: Lmc\CodingStandard\Set\SetList::ALMACAREER

@szepeviktor
Copy link
Author

And please use a name:

Now I have to learn, how to create a SetList!

@szepeviktor szepeviktor linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add setlist szepeviktor/ALMACAREER_php-coding-standard
2 participants
@OndraM @szepeviktor