Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce complexity #12

Closed
llrs opened this issue Aug 1, 2018 · 1 comment
Closed

Reduce complexity #12

llrs opened this issue Aug 1, 2018 · 1 comment
Assignees
Milestone

Comments

@llrs
Copy link
Owner

llrs commented Aug 1, 2018

Reduce complexity of combineScoresPar and combineScores, to remove the error in #3 and point 2 of #11 :

library("cyclocomp")
cyclocomp_package("BioCor")
#>                name cyclocomp
#> 7     combineScores        28
#> 8  combineScoresPar        24
#> 11          diceSim         7
#> 30     weighted.sum         7
#> 6        combinadic         6
#> 1   addSimilarities         5
#> 27     similarities         5
#> 24       reciprocal         4
#> 29    weighted.prod         4
#> 2            AintoB         3
#> 9    combineSources         3
#> 10              D2J         3
#> 16              J2D         3
#> 3               BMA         2
#> 12 duplicateIndices         2
#> 15      inverseList         2
#> 23            rcmax         2
#> 25        removeDup         2
#> 26          seq2mat         2
#> 28         vdiceSim         2
#> 4    clusterGeneSim         1
#> 5        clusterSim         1
#> 13          geneSim         1
#> 14             Info         1
#> 17  mclusterGeneSim         1
#> 18      mclusterSim         1
#> 19         mgeneSim         1
#> 20         mpathSim         1
#> 21          pathSim         1
#> 22  pathSims_matrix         1
@llrs
Copy link
Owner Author

llrs commented Sep 15, 2018

The combineScores functions has been reduced to complexity below 20 with the creation of new auxiliary functions.

@llrs llrs closed this as completed Sep 15, 2018
@llrs llrs self-assigned this Sep 15, 2018
@llrs llrs added this to the Version 1.6 milestone Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant