From 035646ecac8b6a67f2b5c5461624dae357db8309 Mon Sep 17 00:00:00 2001 From: Denilson Velasquez <66847768+DeeTheDev@users.noreply.github.com> Date: Mon, 16 Sep 2024 16:31:25 -0400 Subject: [PATCH 1/2] Change pagination layout - Remove pagination if there are no lines - Also, since an empty space looks weird, add a 'no transactions' message --- webapp/src/pages/LedgersOverview.jsx | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/webapp/src/pages/LedgersOverview.jsx b/webapp/src/pages/LedgersOverview.jsx index 00474bc7..5d3a9810 100644 --- a/webapp/src/pages/LedgersOverview.jsx +++ b/webapp/src/pages/LedgersOverview.jsx @@ -109,12 +109,16 @@ export default function LedgersOverview() { linesLoading={ledgersOverviewLoading || ledgerLinesLoading} /> - setListQueryParams({ page: pg })} - scrollTop={140} - /> + {!isEmpty(activeLines) ? ( + setListQueryParams({ page: pg })} + scrollTop={140} + /> + ) : ( + {t("payments:no_transaction_history")} + )} > )} From 347e030bef77a1c04761c1d5ede0d1e66fc289fd Mon Sep 17 00:00:00 2001 From: Denilson Velasquez <66847768+DeeTheDev@users.noreply.github.com> Date: Tue, 17 Sep 2024 12:58:24 -0400 Subject: [PATCH 2/2] Remove confusing no-charges message --- webapp/src/pages/LedgersOverview.jsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/webapp/src/pages/LedgersOverview.jsx b/webapp/src/pages/LedgersOverview.jsx index 5d3a9810..9ce08475 100644 --- a/webapp/src/pages/LedgersOverview.jsx +++ b/webapp/src/pages/LedgersOverview.jsx @@ -109,15 +109,13 @@ export default function LedgersOverview() { linesLoading={ledgersOverviewLoading || ledgerLinesLoading} /> - {!isEmpty(activeLines) ? ( + {!isEmpty(activeLines) && ( setListQueryParams({ page: pg })} scrollTop={140} /> - ) : ( - {t("payments:no_transaction_history")} )} >
{t("payments:no_transaction_history")}