Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text clipping in title #70

Open
davegirdy opened this issue Oct 18, 2017 · 4 comments
Open

Text clipping in title #70

davegirdy opened this issue Oct 18, 2017 · 4 comments

Comments

@davegirdy
Copy link

Hey all, thanks for the awesome plugin!!

I'm noticing an issue where the text gets clipped in the title, especially when using capital letters. Has anyone else seen this? Or have a quick fix? I tried a few things with no luck so far. Using Firefox at the moment.

swal({
title: "Text With Capital Letters",
text: "Text is getting clipped",
type: "success",
showCancelButton: true,
confirmButtonClass: "btn-success",
confirmButtonText: "Okay",
closeOnConfirm: false
},
function () {}
);

clipping1
clipping2

@davegirdy davegirdy changed the title Test clipping in title Text clipping in title Oct 18, 2017
@alekitto
Copy link
Collaborator

Mh, that's wierd.. Anyway I tried to reproduce this error with the snippet you've provided on the demo page and the result differs from yours (I've tested it on Firefox on MacOS)

capital_letters

As you can see the margins for the icon element and the headings are totally different, maybe a custom css rule is interfering with .sa-placeholder element?

@davegirdy
Copy link
Author

Wow, thanks for the super fast reply! I'm using Windows for testing at the moment. I didn't write any custom css rules... but my version of bootstrap is a bit outdated. I didn't install sweetalert, just simply copied sweetalert.css & sweetalert.min.js from the dist folder to mine. I'll try a few more things and close the issue if it's on my side. Thanks!

@alekitto
Copy link
Collaborator

The dist folder is in sync with the contents of lib and including files from it should work the same as the install and build process.
Anyway can you please post your browser version and the bootstrap version too? I would like to test it against a windows VM into IE and Edge.

@davegirdy
Copy link
Author

This issue seems to be fixed by upgrading to Bootstrap to the 4.0.0 beta. I am seeing the bug with Bootstrap v3.3.7 on Firefox (56.0.1 (64-bit)) and Chrome (Version 62.0.3202.62)

I attached the files I'm using for testing. Thanks for looking into this!
sweetalert.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants