Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkdeclarative #218

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-449-nosync branch 3 times, most recently from fbead42 to e5b1c63 Compare January 7, 2025 03:31
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#449
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • dquickextendregister_p.h文件中新增了dqmlglobalobject_p.h的引用,需要确认是否有必要,以及是否遵循了项目的依赖管理规则。
  • DColorForeign命名空间中新增了QML_NAMED_ELEMENT(Color)QML_FOREIGN_NAMESPACE(DTK_QUICK_NAMESPACE::DColor),需要检查这些宏是否正确使用,并且是否与现有的QML元素定义保持一致。
  • DPlatformHandleForeign结构体中新增了QML_UNCREATABLE("PlatformHandle"),需要确认这个改动是否符合业务逻辑需求,并且是否有相应的测试用例来验证这个改动。
  • DColor类中移除了QML_ANONYMOUSQML_NAMED_ELEMENT(Color)QML_UNCREATABLE("Color is only available as enums."),并新增了QML_VALUE_TYPE(dcolor),需要确认这个改动是否是为了支持新的QML特性,并且是否有相应的文档更新来解释这个改动。

是否建议立即修改:

  • 确认新增的依赖和宏的使用是否符合项目规范。
  • 验证QML_UNCREATABLEQML_VALUE_TYPE的使用是否符合业务逻辑和QML引擎的要求。
  • 确保所有改动都有相应的测试用例来保证代码的质量和稳定性。
  • 如果移除的宏是必要的,需要提供替代方案或者解释为什么需要移除。

@18202781743 18202781743 merged commit b827ea4 into master Jan 7, 2025
11 of 13 checks passed
@18202781743 18202781743 deleted the sync-pr-449-nosync branch January 7, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants