Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer should warn on old lottie schema versions #21

Open
simbleau opened this issue May 21, 2024 · 2 comments
Open

Importer should warn on old lottie schema versions #21

simbleau opened this issue May 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@simbleau
Copy link
Member

#10 has discovered that old lottie files don't import as expected, and with the recent LAC establishment, and coming versioning of Lottie files, we should be aware of what schema versions we support and produce a log or error when old versions of bodymovin are used.

@simbleau simbleau added the enhancement New feature or request label May 21, 2024
@cfagot
Copy link

cfagot commented Jul 25, 2024

Related, the error message on failed import is not useful. E.g., when opening an older version I get this:

Json(Error("data did not match any variant of untagged enum AnyAsset", line: 1, column: 363145))

Detecting version would be enough to avoid this case since it was an old version, but would be nice if a corrupted file could be caught with an error that indicates where things went wrong. (But version check is probably enough).

@simbleau
Copy link
Member Author

simbleau commented Jul 25, 2024

Related, the error message on failed import is not useful. E.g., when opening an older version I get this:

Json(Error("data did not match any variant of untagged enum AnyAsset", line: 1, column: 363145))

Detecting version would be enough to avoid this case since it was an old version, but would be nice if a corrupted file could be caught with an error that indicates where things went wrong. (But version check is probably enough).

Right, because we parse the file regardless of the bodymovin version on the file.

A quick win would be asserting the bodymovin version is 5+, since we know version 4 and sooner won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants