You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#10 has discovered that old lottie files don't import as expected, and with the recent LAC establishment, and coming versioning of Lottie files, we should be aware of what schema versions we support and produce a log or error when old versions of bodymovin are used.
The text was updated successfully, but these errors were encountered:
Related, the error message on failed import is not useful. E.g., when opening an older version I get this:
Json(Error("data did not match any variant of untagged enum AnyAsset", line: 1, column: 363145))
Detecting version would be enough to avoid this case since it was an old version, but would be nice if a corrupted file could be caught with an error that indicates where things went wrong. (But version check is probably enough).
Related, the error message on failed import is not useful. E.g., when opening an older version I get this:
Json(Error("data did not match any variant of untagged enum AnyAsset", line: 1, column: 363145))
Detecting version would be enough to avoid this case since it was an old version, but would be nice if a corrupted file could be caught with an error that indicates where things went wrong. (But version check is probably enough).
Right, because we parse the file regardless of the bodymovin version on the file.
A quick win would be asserting the bodymovin version is 5+, since we know version 4 and sooner won't work.
#10 has discovered that old lottie files don't import as expected, and with the recent LAC establishment, and coming versioning of Lottie files, we should be aware of what schema versions we support and produce a log or error when old versions of bodymovin are used.
The text was updated successfully, but these errors were encountered: