Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Bug: values in "font properties" only apply when changing cursor focus #255

Open
felipesanches opened this issue Jul 1, 2021 · 0 comments
Labels
bug Something isn't working UX

Comments

@felipesanches
Copy link

felipesanches commented Jul 1, 2021

If I edit a value in the "font properties" dialog, it will only apply if I click on another text box in that same dialog, or if I press the TAB key.

For instance, if I edit the font family name and immediately click the "Done" button, the edit is ignored.

This dialog seems to mix two mental models:

  • "Immediate editing" - changes are applied as we tweak the data in the dialog
  • "Commit editing" - dialogs that use a "Done" or "OK" button to make the edits effective only when the dialog is closed.

We should choose a single model and stick to it.
For instance, if we choose "immediate editing", then I'd suggest applying the changes at every value change (such as when pressing a key or when pasting from text clipboard). Then the "Done" would be redundant, so it could be ditched and the user would simply click out of the dialog area to close it.

For "commit editing", all changes would apply upon clicking "Done", not earlier. And would use the contents of the text fields.

@cmyr cmyr added bug Something isn't working UX labels Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX
Projects
None yet
Development

No branches or pull requests

2 participants