Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI icons to a UFO file in the resources directory #248

Open
eliheuer opened this issue May 7, 2021 · 4 comments
Open

Move UI icons to a UFO file in the resources directory #248

eliheuer opened this issue May 7, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@eliheuer
Copy link
Collaborator

eliheuer commented May 7, 2021

An idea from a discussion in this pull request: #247

Would it be possible to load icons from a UFO file in the resources directory? Currently, I am drawing the icons in Runebender and pasting them into the toolbar.rs file (see the screenshot below).

rb-icons

I have a git repo for the icon UFOs I have worked with so far here. It might be nice to just add a UFO like this to the resources directory so an external repo isn't needed to track these files.

@eliheuer eliheuer self-assigned this May 7, 2021
@eliheuer eliheuer added the enhancement New feature or request label May 7, 2021
@eliheuer eliheuer removed their assignment May 7, 2021
@alerque
Copy link

alerque commented May 7, 2021

Definitely the right move, the actual icon source that a developer could tweak without starting from scratch should not be in a separate repository ;-)

Since toolbar icons aren't a full fledged font and don't need kerning or OpenType features or anything, perhaps storing a full UFA isn't necessary and just bare .glif files would be enough.

@ctrlcctrlv
Copy link

Being able to edit detached (unparented) .glif files is a must if you ask me, but I'm trying not to comment here too much given that I, you know, am the BD of a competing project. ;-)

@eliheuer
Copy link
Collaborator Author

eliheuer commented May 7, 2021

There is some further discussion about this going on here: #248

I haven't tried it myself, but @ctrlcctrlv's idea about loading just .glif files in the editor seems like it would work well for this.

@cmyr
Copy link
Member

cmyr commented May 8, 2021

I agree this makes total sense. I also think individual glif files is a nice idea; I've been thinking it would be nice to try and keep the coupling between runebender and the UFO format a little bit loose, and supporting some basic non-UFO cases is a good way to force that, and individual glif files would be a very simple way to do that, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants