Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to warn or error in pre-commit on the PPT version check #356

Open
drewoldag opened this issue Jan 30, 2024 · 0 comments
Open

Option to warn or error in pre-commit on the PPT version check #356

drewoldag opened this issue Jan 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@drewoldag
Copy link
Collaborator

Currently the LF-PPT version check pre-commit hook will always pass, even if the template that a project uses is out of date.

Given that many people don't use pre-commit locally, but we run it as part of CI, we could allow users to choose error (and be "forced" to update to the latest version) or warn (that will simply produce the warning message).

Also, should we run pre-commit as part of smoke tests specifically for the reason called out?

@delucchi-cmu delucchi-cmu added the enhancement New feature or request label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants