-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage calculation to pre-commit stages #321
Comments
It would be nice if we could output the total coverage during the pre-commit step. This would give a heads up to let the user know that the github workflow might fail. |
We're already calculating the code coverage amounts, so this would be a matter of twiddling with the output/verbosity options to get something useful. The best I've come up with is below, and is basically using the pytest command
I like it:
I don't like it:
|
We have codecov in CI actions, so we'll leave this as is for now. |
I'm bummed when everything in pre-commit passes locally, then the github workflow lets me know that there's one new line that doesn't have test coverage.
Always aiming for 100% is a high bar, but even a warning that you're reducing coverage would be great!
The text was updated successfully, but these errors were encountered: