Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psoct.multi_slice: do not require a channel dimension #26

Closed
balbasty opened this issue Nov 21, 2024 · 2 comments
Closed

psoct.multi_slice: do not require a channel dimension #26

balbasty opened this issue Nov 21, 2024 · 2 comments

Comments

@balbasty
Copy link
Collaborator

In the multi_slice OCT converter, it is assumed that the onput file contains a channel dimension.

It is the case in some of our data, but not in the minnesota data, and potentially not in some of our (non orientation) data as well.

It would be good to have a flag to handle the presence or absence of a channel dimension.

@calvinchai

@balbasty
Copy link
Collaborator Author

balbasty commented Nov 21, 2024

Weirdly, the single_volume script does not expect a channel dimension, but expects the data to be 3D. Maybe this one should also have flags to handles the 2D/3D and channel/no-channel cases?

@balbasty
Copy link
Collaborator Author

Fixed by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant