Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tour Operator plugin to meet WordPress Coding Standards before pushing 2.0 release to wordpress.org #358

Closed
ashleyshaw opened this issue Oct 9, 2024 · 3 comments · Fixed by #452 or #447
Closed

Tour Operator plugin to meet WordPress Coding Standards before pushing 2.0 release to wordpress.org #358

ashleyshaw opened this issue Oct 9, 2024 · 3 comments · Fixed by #452 or #447
Assignees
@krugazul @ZaredRogers
Labels
[Status] Needs More Info Follow-up required in order to be actionable. [Type] Code Quality Issues or PRs that relate to code quality & coding standards [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
2.0.0

Comments

@ashleyshaw
Copy link
Member

ashleyshaw commented Oct 9, 2024 •
edited
Loading

Ensure Tour Operator Plugin Meets WordPress Coding Standards

Issue Summary

Before we push the upcoming 2.0 release of the Tour Operator plugin to WordPress.org, we need to ensure the entire codebase adheres to WordPress Coding Standards.

Steps to be Completed:

  1. Run Plugin Check: Use the Plugin Check Plugin to verify compliance with WordPress.org guidelines.
  2. Run PHPCS: Use PHP_CodeSniffer with the WordPress Coding Standards to identify any code violations.
    • Command: phpcs --standard=WordPress .
  3. Resolve PHPCS Violations: Address flagged issues while maintaining functionality.
  4. Check JavaScript Standards: Ensure all JavaScript files comply with WordPress JavaScript Coding Standards.
    • Command: eslint --config=eslint-config-wordpress .
  5. Update Documentation: Ensure proper inline documentation in accordance with WordPress PHP Documentation Standards.
  6. Final Review: Perform a final code review to confirm readiness for the 2.0 release.

Acceptance Criteria:

  • Plugin passes all Plugin Check and coding standard checks.
  • No PHPCS or ESLint errors.
  • All documentation adheres to standards.
  • Plugin is ready for submission to WordPress.org.

Related Links:
@ashleyshaw ashleyshaw added [Status] Needs More Info Follow-up required in order to be actionable. [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Code Quality Issues or PRs that relate to code quality & coding standards labels Oct 9, 2024
@ashleyshaw ashleyshaw added this to the 2.0.0 milestone Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Tour Operator Oct 9, 2024
@ashleyshaw ashleyshaw moved this from Needs Triage to 📥 Todo in Tour Operator Oct 9, 2024
@krugazul
Copy link
Collaborator

PHPCS fixes in these 3 pull requests

@krugazul
Copy link
Collaborator

Image

@github-project-automation github-project-automation bot moved this from 📥 Needs Dev to ✅ Done in Tour Operator Dec 20, 2024
@krugazul
Copy link
Collaborator

The errors are hidden files, that will be removed before adding to the repo

This was linked to pull requests Jan 10, 2025
2.0 beta 3 enhancements 1 #452
Merged
Beta 2 bugfixes 3 #447
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krugazul krugazul

@ZaredRogers ZaredRogers

Labels
[Status] Needs More Info Follow-up required in order to be actionable. [Type] Code Quality Issues or PRs that relate to code quality & coding standards [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
Tour Operator
Status: ✅ Done
Milestone
2.0.0
3 participants
@ashleyshaw @krugazul @ZaredRogers