Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: add get transaction rpc #7323

Closed
benthecarman opened this issue Jan 15, 2023 · 17 comments · Fixed by #7654
Closed

[feature]: add get transaction rpc #7323

benthecarman opened this issue Jan 15, 2023 · 17 comments · Fixed by #7654
Assignees
@ErikEk
Labels
database Related to the database/storage of LND enhancement Improvements to existing features / behaviour good first issue Issues suitable for first time contributors to LND P1 MUST be fixed or reviewed rpc Related to the RPC interface
Milestone
v0.18.0

Comments

@benthecarman
Copy link
Contributor

Is your feature request related to a problem? Please describe.

There should be a get transaction rpc instead of having to use the get transactions rpc and find the specific transaction you want.

My node has done over 1k transactions and it would be nice to not have to load it all into memory and find something myself when lnd could easily do it.
@benthecarman benthecarman added the enhancement Improvements to existing features / behaviour label Jan 15, 2023
@benthecarman benthecarman changed the title [feature]: [feature]: add get transaction rpc Jan 15, 2023
@yyforyongyu yyforyongyu added the good first issue Issues suitable for first time contributors to LND label Jan 15, 2023
@positiveblue
Copy link
Contributor

Are we talking about the lncli listchaintxns here? What do you usually search by: tx_hash, previous_outpoints?

@benthecarman
Copy link
Contributor Author

benthecarman commented Jan 15, 2023 •
edited
Loading

Yeah exactly, tx hash would be the simplest

@saubyk saubyk added this to the v0.17.0 milestone Jan 17, 2023
@saubyk saubyk added wallet The wallet (lnwallet) which LND uses rpc Related to the RPC interface database Related to the database/storage of LND and removed wallet The wallet (lnwallet) which LND uses labels Jan 19, 2023
@gnapoli23
Copy link

Hi, a newcomer here! I would like to work on it, can you give me a bit of context? Thanks! :)

@ErikEk
Copy link
Contributor

ErikEk commented Jan 26, 2023 •
edited
Loading

@gnapoli23 I almost completed it. But since you are new here you can get the code if you want to finish it.

@gnapoli23
Copy link

gnapoli23 commented Jan 26, 2023 •
edited
Loading

@ErikEk
Oh, nevermind. Keep on going. I'll take a look for something else :)

@ErikEk
Copy link
Contributor

ErikEk commented Jan 26, 2023 •
edited
Loading

Great

@gnapoli23 gnapoli23 mentioned this issue Feb 3, 2023
Closed
@gnapoli23
Copy link

I didn't see any PR linked to the issue in a week, so I started to work on it.

@ErikEk
Copy link
Contributor

ErikEk commented Feb 3, 2023

@gnapoli23 I didn't abandon it. Was waiting for the 0.16 release. If you want to do it instead, go ahead.

@positiveblue
Copy link
Contributor

@ErikEk Do you mind chiming in #7378? You said you were almost done so feel free to create a draft PR.

Given that you had already implemented a working (or almost) version of it, do you mind sharing what approach you followed?

@ErikEk
Copy link
Contributor

ErikEk commented Feb 3, 2023

@positiveblue Absolutely.

@lujakob lujakob mentioned this issue Apr 19, 2023
Closed
@benthecarman
Copy link
Contributor Author

Any updates on this? This is desperately needed, my node has reached the point where it is greater than the grpc max message size when calling get transactions.

@ErikEk
Copy link
Contributor

ErikEk commented Apr 27, 2023 •
edited
Loading

I will see what I can do. Looks like the guy abandoned it.

@ErikEk ErikEk mentioned this issue May 1, 2023
Merged
@abitcoinperson
Copy link

Gonna bump this again.

@saubyk saubyk modified the milestones: v0.18.0, v0.17.1 Jul 1, 2023
@saubyk saubyk assigned ErikEk and unassigned gnapoli23 Jul 1, 2023
@saubyk
Copy link
Collaborator

saubyk commented Jul 1, 2023 •
edited
Loading

Gonna bump this again.

Looks like the pr has made progress and got some reviews. Tagging this issue for 0.17.1

@saubyk saubyk added the P1 MUST be fixed or reviewed label Aug 8, 2023
@saubyk saubyk removed this from the High Priority milestone Aug 8, 2023
@markettes
Copy link
Contributor

Is progress being made here or may I jump into this?

@ErikEk
Copy link
Contributor

ErikEk commented Nov 3, 2023

@markettes Almost done. Had to change btcwallet so it took some extra time.
#7654

@markettes
Copy link
Contributor

Sure, no worries. I was looking for something to work on 😃

@saubyk saubyk added this to lnd v0.18 Dec 3, 2023
@saubyk saubyk moved this to 👀 In review in lnd v0.18 Dec 3, 2023
@saubyk saubyk added this to the v0.18.0 milestone Dec 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in lnd v0.18 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErikEk ErikEk

Labels
database Related to the database/storage of LND enhancement Improvements to existing features / behaviour good first issue Issues suitable for first time contributors to LND P1 MUST be fixed or reviewed rpc Related to the RPC interface
Projects
lnd v0.18
Status: ✅ Done
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

rpc: add gettx command to walletrpc ErikEk/lnd
[wip]: add get transaction rpc gnapoli23/lnd
8 participants
@gnapoli23 @positiveblue @yyforyongyu @abitcoinperson @ErikEk @benthecarman @markettes @saubyk