Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ui/analyse/src/ctrl.ts, have this.data.game.status be updated on each move/jump #16789

Open
johndoknjas opened this issue Jan 17, 2025 · 1 comment

Comments

@johndoknjas
Copy link
Contributor

I added the following debugging code in a branch of mine (the only relevant line is 596, and the issue isn't specific to premove scenarios):

Image

I also made a study chapter that initially was not in a drawn state:

Image

Then once playing a move to reach a stalemate, and doing a premove to trigger my console.log statement:

Image

The status is incorrectly still 'created', when it should be 'stalemate' or at least 'draw'.

Note that if the initial position of the chapter were drawn, the status is correct. E.g. (ignore the other unhinged debugging statements):

Image

Image

If this is fixed, it would allow #16679 to rely on computations from the backend rather than the frontend, and make the logic cleaner. I've tried to fix it myself but haven't been successful.

@schlawg
Copy link
Collaborator

schlawg commented Jan 19, 2025

Note - this PR and #16679 both touch on areas of client analysis code that are likely to be disconnected from lila-ws and rewritten to use chessops within a month or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants