Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] drop cronet #6867

Open
3 tasks done
Bnyro opened this issue Dec 8, 2024 · 3 comments
Open
3 tasks done

[meta] drop cronet #6867

Bnyro opened this issue Dec 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Bnyro
Copy link
Member

Bnyro commented Dec 8, 2024

Describe your suggested feature

F-Droid recently started marking Cronet unfree and thus LibreTube must be dropping that dependency to continue being updated on F-Droid, see #6455.

The whole downloader depends on Cronet, so that'll require a large refactor.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Bnyro Bnyro added the enhancement New feature or request label Dec 8, 2024
@FireMasterK
Copy link
Member

https://gitlab.com/fdroid/fdroid-suss/-/blob/master/suss/com.google.android.gms.yml

It seems to just be the media3 cronet dependency. This is likely because of this:
https://github.com/androidx/media/blob/1a7da45dd9c6419a43fab95132ed0aa0999300aa/libraries/datasource_cronet/build.gradle#L27

Maybe we can ask them if it's okay to use it without the gms dependency?

@FireMasterK
Copy link
Member

FireMasterK commented Dec 9, 2024

If there's a big issue with the dependency, we could just copy the Java code from the dependency into LibreTube's code (since its apache 2), or maintain a minimal version of the library?

Edit: see https://github.com/FireMasterK/LibreTube/tree/media3-cronet

@Bnyro
Copy link
Member Author

Bnyro commented Jan 9, 2025

I don't think that inlining the whole Cronet source code is a good idea and I don't want to maintain a fork of an external library either, so I'll probably remove Cronet with the next release until there's a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants