From c91ecbc8a279a87c9abfb8b0d2f76195f39b7298 Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Mon, 16 Oct 2023 17:43:06 +1100 Subject: [PATCH] ci: don't run changelog check on chores and refactor PRs We don't always want to write a changelog entry or bump the version of a crate when we make changes to it. This especially applies to refactorings and other chores. We can automatically detect such PRs based on our conventional commit title. At the moment, this is not per crate but could be extended in the future. For now, this should be good enough to unblock PRs that are currently stuck on this workflow. Pull-Request: #4658. --- .github/workflows/ci.yml | 5 ++++- protocols/kad/CHANGELOG.md | 6 ------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 66f686e58ea..dcfb6bd21be 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -73,7 +73,10 @@ jobs: test "$PACKAGE_VERSION" = "$SPECIFIED_VERSION" - name: Ensure manifest and CHANGELOG are properly updated - if: github.event_name == 'pull_request' + if: > + github.event_name == 'pull_request' && + !startsWith(github.event.pull_request.title, 'chore') && + !startsWith(github.event.pull_request.title, 'refactor') run: | git fetch origin master:master ./scripts/ensure-version-bump-and-changelog.sh diff --git a/protocols/kad/CHANGELOG.md b/protocols/kad/CHANGELOG.md index d4cc1f6c030..cfc0f325308 100644 --- a/protocols/kad/CHANGELOG.md +++ b/protocols/kad/CHANGELOG.md @@ -8,12 +8,6 @@ [PR 4547]: https://github.com/libp2p/rust-libp2p/pull/4547 - - ## 0.44.5 - Migrate to `quick-protobuf-codec` crate for codec logic. See [PR 4501].