From a99b7450ec2725c248bd426e4a2e8820cd6a762c Mon Sep 17 00:00:00 2001 From: Lewis Blackburn Date: Mon, 9 Sep 2024 21:03:36 +0100 Subject: [PATCH] Refactor user menu button in 2fa.test.ts and onboarding.test.ts --- tests/e2e/2fa.test.ts | 2 +- tests/e2e/onboarding.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/e2e/2fa.test.ts b/tests/e2e/2fa.test.ts index 36261d7..fec2e2d 100644 --- a/tests/e2e/2fa.test.ts +++ b/tests/e2e/2fa.test.ts @@ -33,7 +33,7 @@ test('Users can add 2FA to their account and use it when logging in', async ({ // await expect(main).toHaveText(/You have enabled two-factor authentication./i) await expect(main.getByRole('link', { name: /disable 2fa/i })).toBeVisible() - await page.getByRole('button', { name: `${user.name} Toggle user` }).click() + await page.getByRole('link', { name: user.name ?? user.username }).click() await page.getByRole('button', { name: /logout/i }).click() await expect(page).toHaveURL(`/`) diff --git a/tests/e2e/onboarding.test.ts b/tests/e2e/onboarding.test.ts index 453f993..4c6e65c 100644 --- a/tests/e2e/onboarding.test.ts +++ b/tests/e2e/onboarding.test.ts @@ -102,7 +102,7 @@ test('onboarding with link', async ({ page, getOnboardingData }) => { await expect(page).toHaveURL(`/dashboard`) await page - .getByRole('button', { name: `${onboardingData.name} Toggle user` }) + .getByRole('link', { name: onboardingData.name ?? onboardingData.username }) .click() await page.getByRole('menuitem', { name: /profile/i }).click() @@ -112,7 +112,7 @@ test('onboarding with link', async ({ page, getOnboardingData }) => { await page.waitForTimeout(1000) await page - .getByRole('button', { name: `${onboardingData.name} Toggle user` }) + .getByRole('link', { name: onboardingData.name ?? onboardingData.username }) .click() await page.getByRole('menuitem', { name: /logout/i }).click() await expect(page).toHaveURL(`/`)