Bugfix in parsing LegendDataConfig on Windows
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 48.96% 48.96%
=======================================
Files 15 15
Lines 966 966
=======================================
Hits 473 473
Misses 493 493 ☔ View full report in Codecov by Sentry. |
|
Nice, no more failing tests on Windows |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests on Windows keep on failing since implementing the support for colon-separated filenames in
LEGEND_DATA_CONFIGin commit 80b0c11.What happens is that
LEGEND_DATA_CONFIGis split at every colon, including the colons that might belong to a Windows file path (C:\\...). In this PR, I replaced the simple':'as the split condition with a regular expressionr":(?!\\)to avoid splitting:\\as expected in Windows file paths.I hope that the tests on Windows will pass again with this fix.