Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to read pars #11

Closed
theHenks opened this issue Jul 26, 2023 · 3 comments
Closed

Add possibility to read pars #11

theHenks opened this issue Jul 26, 2023 · 3 comments

Comments

@theHenks
Copy link
Collaborator

We need a pars reader which works in the same fashion as the metadata reader. It should respect the validity files and just read the propdicts out of the pars folder instead of the metadata folder.
It should work like

calib_pars = l200.par.cal(ValiditySelection)[detector]

The folder for cal currently contains then the period name and runs following. But, it would be nice to have the validity selection independent of the runs and periods. so the selection should be possible on the cal folder level. In addition, a feature like

calib_pars = l200.par.cal[period, run]

would also be nice to just get pars for a specific run.
I think this should be straightforward to implement.
Maybe I can make a draft PR and then we see how this looks like. Or @oschulz, do you have some time?

@theHenks theHenks changed the title Add possibility to read Add possibility to read pars Jul 26, 2023
@oschulz
Copy link
Contributor

oschulz commented Jul 26, 2023

I'll see that I do that next week - but remind me :-)

@theHenks
Copy link
Collaborator Author

Thanks to @fhagemann , there is already a draft version on the ceph. He implemented a similar functionality than we have for the metadata and config reader. Looks very very nice, so big thanks to Felix!

@oschulz
Copy link
Contributor

oschulz commented Dec 13, 2023

Can we close this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants