Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split reducers into different files, or change state logic #7

Open
leftmove opened this issue Mar 23, 2024 · 11 comments
Open

Split reducers into different files, or change state logic #7

leftmove opened this issue Mar 23, 2024 · 11 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@leftmove
Copy link
Owner

Currently, wallstreetlocal uses Redux to manage all the complex, global state for different filers. This leads to a couple problems.

  • All reducers are housed in a single, big file, and it is hard to manage them
  • Things tend to get unorganized when creating new reducers, they should be more compartmentalized
  • Performance can be slow when loading many reducers
  • Lots of boilerplate, including complex, and perhaps unnecessary Redux logic

Redux settings probably need to be tweaked to implement more best practices. filerSlice.js is a big file, and loading it dynamically, if possible, could improve performance.

Or maybe the best solution is to abandon Redux altogethor, and adopt a new (or no) state library.

@leftmove leftmove added the good first issue Good for newcomers label Apr 3, 2024
leftmove added a commit that referenced this issue May 28, 2024
@shubham9069
Copy link

@leftmove I am new in this open-source world but I have a working experience As a Software developer so I want to make a small contribution to your vision can I be capable of doing it?

@leftmove
Copy link
Owner Author

leftmove commented Jul 3, 2024

Absolutely! Depending on your experience, this issue may be a bit complex and will take a while to understand.

Let me know which technologies you are most experienced in, and I can point you in the right direction.

@shubham9069

@shubham9069
Copy link

@leftmove I worked On MERN as well as had experience in Angular. you can checkout my portfolio which gives me brief explanation of me and my work https://shubhamkaushik-portfolio.vercel.app/

@leftmove
Copy link
Owner Author

leftmove commented Jul 3, 2024

@shubham9069

It seems you are a seasoned React developer; this gives you a couple of options depending on what you want to dip your toes in.

  • This issue requires fairly in depth knowledge of Redux.js - a state management tool. I would not recommend it unless you really want to learn all about Redux (especially since many other state management libraries are trending up nowadays).
  • Create charts. This is the issue I would recommend the most to you. Basically, you have to take in data and use your knowledge of JavaScript and React to create charts for that data. It would be good practice for any React developer.
  • Migration to Next.js app router. This is the easiest but most tedious issue; I would also recommend it. Basically, you just have to update all the dependencies and get the entire app running on Next.js's newest version. It will require lots of refactorings, but there are many guides.

Whatever you choose, please let me know and do not hesitate to ask for help. I'll assign you as soon as possible and give you some tips to start off.

Thank you!

@shubham9069
Copy link

@leftmove I understand your concern but redux is also built on top of content API and I have prophecy in state Management using Context API. and second yeah I Would Love to contribute other 2 tasks

@mustafa-tola
Copy link

I would love to work on this task as i have previously worked on redux

@aadarsh10c
Copy link

Hey @leftmove , looks like person assigned this issue is not working, i would like to contribute to this issue. Please assign me this issue

@leftmove
Copy link
Owner Author

@mustafa-tola @aadarsh10c

Sorry for the late reply, have at it.

@mustafa-tola
Copy link

@leftmove i have done some work regarding this issue how can i test it sorry for the delay

@leftmove
Copy link
Owner Author

@mustafa-tola Easiest way to test is to run the front-end with npm run dev and make sure all the components are working.

@mustafa-tola
Copy link

mustafa-tola commented Dec 2, 2024

@leftmove i have splitted the reducer into 3 different slices. Now i want to push it so that you can check if it is working. how can i do it. i have checked on my side. it is working but i want to cross check with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants