Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - Incorrect snack bar notification when bulk editing resources #4654

Closed
pcenov opened this issue Aug 16, 2024 · 4 comments · Fixed by #4671
Closed

Unstable - Incorrect snack bar notification when bulk editing resources #4654

pcenov opened this issue Aug 16, 2024 · 4 comments · Fixed by #4671

Comments

@pcenov
Copy link
Member

pcenov commented Aug 16, 2024

Observed behavior

When I am bulk editing resources if I select the Apply to all resources and folders nested within the selected folders and I click 'Save' then I see an incorrect snack bar message that I've just edited 1 resource.

Expected behavior

Correct number of edited resources, or stating that multiple resources have been edited.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel with folders and all of the supported resources
  3. Select a folder with multiple resources and bulk edit all of the resources within the folder
  4. Observe the snack bar message

Additional information

message.2.mp4

Console logs

no errors observed in the console

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Aug 16, 2024

@radinamatic

@marcellamaki
Copy link
Member

I think here we can just remove the reference to resources entirely and have the snackbar say "Edited 'levels'" or "Edited 'categories'" ?

I'm not sure the level of granular detail with the number of resources is really required, since the action has already been completed. How does that sound? @radinamatic (and @pcenov if you have any ideas!)

@radinamatic
Copy link
Member

Yes, we were considering an more generic wording, and actually we already have the Changes saved string (we have it in 3 places, for that matter 😂, some cleanup needed) on Crowdin.

@radinamatic
Copy link
Member

Manual QA on the unstable branch confirms the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants