Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - Seeing the 'Incomplete' icon for each new resource I upload #4644

Closed
pcenov opened this issue Aug 15, 2024 · 6 comments · Fixed by #4697
Closed

Unstable - Seeing the 'Incomplete' icon for each new resource I upload #4644

pcenov opened this issue Aug 15, 2024 · 6 comments · Fixed by #4697
Assignees
Labels
bug DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Aug 15, 2024

Observed behavior

Each time I upload a new file I see the 'Incomplete' icon for no obvious reason. If I open again the resource in edit mode and just close the modal the icon disappears.

Expected behavior

The 'Incomplete' icon should be displayed only for resources which area actually incomplete.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel and upload a file (pdf, epub, mp4, webm)
  3. Exit the 'Edit details' modal and observe the incomplete icon displayed next to the title of the resource

Additional information

incomplete.mp4

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Aug 15, 2024

@radinamatic

@radinamatic
Copy link
Member

Not sure if something is missing from your recording, but did you input the Copyright holder field? I'm not able to replicate this if I just upload the file and edit the resource title as in the screencast, I always get the alert modal that the resource is incomplete and missing the Copyright holder if I try to finish 🤔

@pcenov
Copy link
Member Author

pcenov commented Aug 15, 2024

In my case, the Copyright holder field is specified on channel level, so it's already filled in. In fact that's the essence of the issue that I am describing - I have all of the required fields filled in and I am still seeing the incomplete icon. So in order to replicate it you might need to have the Copyright field specified on channel level?

@radinamatic
Copy link
Member

Ok, important detail was missing, with that I am able to replicate the issue! 👍🏽

@radinamatic radinamatic added bug P0 - critical Priority: Release blocker or regression DEV: frontend labels Aug 15, 2024
@marcellamaki marcellamaki self-assigned this Aug 15, 2024
@marcellamaki marcellamaki removed their assignment Aug 26, 2024
@rtibbles
Copy link
Member

My only thought is that we're not properly setting complete on new content nodes, and it's then being updated after the fact at some point. So maybe we could validate on creation and set complete to true if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants