Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lengthy resource title collides with channel name in import modal #4086

Open
bjester opened this issue May 22, 2023 · 23 comments
Open

Lengthy resource title collides with channel name in import modal #4086

bjester opened this issue May 22, 2023 · 23 comments
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: ux update

Comments

@bjester
Copy link
Member

bjester commented May 22, 2023

Observed behavior

Reported by @thanksameeelian: When reviewing selections of items to import into a channel, long resource names run up against the names of the channels that contain them
Screen Shot 2023-05-11 at 12 46 29 PM

Expected behavior

No text collisions

@bjester bjester added TAG: ux update good first issue Self-contained, straightforward, low-complexity DEV: frontend labels May 22, 2023
@MisRob
Copy link
Member

MisRob commented Jun 6, 2023

We could move TextTruncatorCss from Kolibri to KDS and then use it in Studio too for cases like this

@bjester
Copy link
Member Author

bjester commented Jun 6, 2023

@MisRob Would you write up something in KDS for this then?

@MisRob MisRob added the help wanted Open source contributors welcome label Aug 18, 2023
@MisRob
Copy link
Member

MisRob commented Sep 22, 2023

@bjester learningequality/kolibri-design-system#450

@bjester bjester added this to the Studio: Q2-24 Release milestone Apr 24, 2024
@bjester bjester added the P2 - normal Priority: Nice to have label Apr 24, 2024
@marcellamaki marcellamaki removed this from the Studio: Q2-24 Release milestone Jul 16, 2024
@ChetanCoder24
Copy link

ChetanCoder24 commented Oct 26, 2024

I am interested in contributing in this issue. @bjester and @MisRob can you please assign me this issue?

@AlexVelezLl
Copy link
Member

Hey @ChetanCoder24! Thank you for your interest in contributing to this issue. I will assign this to you! If you have any question, please let us know 🤗

@MisRob
Copy link
Member

MisRob commented Dec 2, 2024

Hi @ChetanCoder24, are you still planning to work on this?

@Yashkrit-Singh
Copy link

Yashkrit-Singh commented Dec 6, 2024

hi @AlexVelezLl and @MisRob, i am first time contributor and i am interested to contribute in this issue. can you please assign me this issue?

@MisRob
Copy link
Member

MisRob commented Dec 9, 2024

Hi @Yashkrit-Singh, welcome! Thanks for volunteering, I will assign you.

@Yashkrit-Singh
Copy link

Thanks! @MisRob

@Yashkrit-Singh
Copy link

Yashkrit-Singh commented Dec 9, 2024

hi @MisRob, i am confused why my local development server is not running. pyenv is creating difficulty in installation and on running the frontend server alone pyenv is not letting it run locally.

sorry for asking such silly question, its truely my first time doing so and i wanna contribute 😅😅

@MisRob
Copy link
Member

MisRob commented Dec 12, 2024

Hi @Yashkrit-Singh, it's alright to ask this.

I'd ask you to follow closely https://github.com/learningequality/studio/blob/unstable/docs/local_dev_docker.md step by step and keep all the screenshots/logs/recording of the whole process. If you hit an error, it'd be best to open a new post in the Studio Discussions and post as most information you can, and also mention there what's your operating system.

@Yashkrit-Singh
Copy link

Yashkrit-Singh commented Dec 14, 2024

@MisRob local server started working
Image

Thanks for the cooperation

@Yashkrit-Singh
Copy link

hi @MisRob ,
Image
i have added some documents/resources in the Published Channel but on importing resources from other channel, its showing the resource not available
Image

Do i need to publish this to kolibri ?

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

Hi @Yashkrit-Singh,

to be able to access the "Review selections" page when importing to a channel:

  • Login as [email protected]
  • Navigate to "Imported channel"
  • Click "Add" > "Import from channels"
  • Select some non-topic resources from "Published channel"
  • Click "Review"

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

@Yashkrit-Singh and to get a longer text than in the original samples of the "Published channel", you can just override markup in the browser console.

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

@shruti862
Copy link
Contributor

@MisRob I noticed that this issue is currently assigned to @Yashkrit-Singh . If he is currently not working on this issue, would it be possible to assign this issue to me? I’d be happy to work on it.

@AlexVelezLl
Copy link
Member

Hey @Yashkrit-Singh! Are you still interested in working on this issue?

@AlexVelezLl
Copy link
Member

Unassigning due to inactivity. If you are still interested in workingon this issue @shruti862, let me know :).

@shruti862
Copy link
Contributor

Hey @AlexVelezLl ,Yes I am interested to work on this issue, please assign me

@AlexVelezLl
Copy link
Member

Thanks @shruti862! If you have any questions, please let us know :).

@shruti862
Copy link
Contributor

Hey @bjester @AlexVelezLl I have raised a PR could you please review it whenever you gets time and let me know if any changes needed :)

@shruti862
Copy link
Contributor

shruti862 commented Jan 15, 2025

@bjester @AlexVelezLl While resolving this issue I noticed that KTextTruncator Component in KDS does not have usage section so I wanted to know, is there already a Issue open regarding this ??

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: ux update
Projects
None yet
Development

No branches or pull requests

7 participants